Added availability_mobileapp UCSFCLE_403_STABLE

[lbailey-ucsf]

The official release of the Moodle Mobile app availability plugin appears to have not been updated in the past 5 years. Due to open issues in the main branch of the official release, we opted to fork, fix, and deploy our fork for a '4.0' release.

Our forked version passed the phpUnt tests. However, "There were 2 risky tests" reported due to deprecation. PR reviewers can decided whether or not we should address the 'risky tests' prior to integration into our UCSFCLE_404_STABLE branch.

[ctam]

However, "There were 2 risky tests" reported due to deprecation.

Was this issue reported to the Moodle HQ, i.e. was an issue created on the moodlehq/moodle-availability_mobileapp repo? If not, could we create one? And/Or create an Asana ticket for this as well, so we bring this to the surface. If a developer has a free cycle, they could fix it before the next Moodle upgrade.

[lbailey-ucsf]

However, "There were 2 risky tests" reported due to deprecation.

Was this issue reported to the Moodle HQ, i.e. was an issue created on the moodlehq/moodle-availability_mobileapp repo? If not, could we create one? And/Or create an Asana ticket for this as well, so we bring this to the surface. If a developer has a free cycle, they could fix it before the next Moodle upgrade.

@ctam

The "risky tests" was based on a single issue that occurred twice (you can see the full trace in the job run):

Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /home/runner/work/moodle/moodle/availability/condition/mobileapp/classes/condition.php on line 97

Also, the issue has not been report, but I'll report it. I doubt it will be addressed; there hasn't been any activity on that repo in 5 years.

Note that the plugin is passing core unit tests and Brian reviewed in Tugboat and confirmed the functionality

[lbailey-ucsf]

@ucsf-education/moodlecodereviewers any decision on merging this?

[ctam]

I've been reviewing this for the last couple of days. And I added a comment to Issue #3 stating the fact that MOODLE_32_STABLE has the latest changes while master is lagging behind. Our UCSFCLE_403_STABLE was based off MOODLE_32_STABLE. So, it is fine that we are using the same UCSFCLE_403_STABLE branch for Moodle 4.4. But it was not obvious to me or anyone at first. I really wish the plugin maintainer would fix this so we can avoid spending time figuring it out every time we work on this plugin.

It looks good and I will approve and merge this.