-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separated L extraction framework #227
base: master
Are you sure you want to change the base?
Conversation
removed coq-metacoq-template dependency
As I said on the other PR:
Now moving the framework to another repo just means we have to maintain two things, and we buy a dependency in the library once a proof uses a framework. So overall, I think this doesn't improve the situation. |
If removing a
For
Do you have some suggestions on how to improve the situation? |
From my perspective, it would be a good situation to have |
If I understand well, there are two conflicting issues here:
One of the principle we discussed in the earlier days was to not depend heavily on external libraries, precisely to avoid synchronization issues like item 1, and rather include the necessary source code inside the undecidability lib. I found and still find this is a good principle. I do not know if it is applicable to On the other hand, I understand that moving Since @yforster seem to think it is possible/likely that at some point, a new undecidability target might use the I did not heavily review that Would the last proposition of @mrhaandi, putting |
The removal from Coq's CI was, if I remember correctly, also mainly because we are a pure library and do not provide test coverage that other projects don't provide. So I doubt that we'll be reintegrated, so we're back to the state every other Coq project has: We have to keep up with Coq's In the modern days, synchronisation is not a major issue anymore. There's the Coq platform, opam packages are usually relased quickly (MetaCoq was already released when I looked at releasing for Coq 8.20). So in short: I think we're trying to fix a hypothetical future issue here that doesn't exist. (There is no MetaCoq CI because there is no good way in Coq to do "forward" CI. So we can't put L extraction there.) |
According to the Zulip discussion we may get back into the Coq CI if we had no dependencies. |
Currently, no undecidability and computability result strictly depends on the L extraction framework. In order to improve maintainability of the library, the L extraction framework is moved to a separate project https://github.com/uds-psl/L-extraction.
Moving the framework removes the
coq-metacoq-template
dependency, makingcoq
the only dependency.This may enable a reinclusion of
coq-library-undecidability
into Coq CI, cf. coq/coq#19339@yforster @dominik-kirst @DmxLarchey feel free to comment.