-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Scale System #147
Rework Scale System #147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thank you very much for this.
Previously, depending on the user device and orientation, the widgets could end up overlapping and/or looking awkward.
Yeah, I agree. That's still from when I started with Flutter 😅
@ueman The PR is mostly done. I've also made the controls column wrap if it's too tall to fit. I have a couple question around the sheet size if you have a minute:
|
Awesome.
That's fine for me.
Maybe in landscape it shouldn't be a bottom sheet but layout where both things are next to each other? That's probably more sensible because we're having much more horizontal space than vertical. That's probably work for another PR, though. For now, leaving it as it is fine as long as it's not worse than before.
I think I prefer having a fraction available in the FeedbackTheme. It seems reasonable. The docs for it should probably say that the recommended height of the sheet is around a quarter to a third. If you're having trouble with the golden images again, just ignore them and I'll fix it them you want. |
All done! I left the golden images and changelog/version bumping to you. The changes to support a draggable bottom sheet are near done too so if you want to do one update, I could get the bottom sheet done pretty quick once this is merged. Let me know if you think this PR needs any changes! |
I'm going to close this, as the changes are also included in #149 |
📜 Description
This PR completely reworks the
feedback_widget
to useCustomMultiChildLayout
instead ofStack
.💡 Motivation and Context
This has a number of advantages:
I was especially finding the existing system to be too unmanageable while trying to update the bottom sheet to be a draggable sheet.
TODO:
sheetFraction
inFeedbackThemeData
? ❔💚 How did you test it?
Goofed off with the example widget. Soon to add this to my existing app via a path dependency.
📝 Checklist
🔮 Next steps