Custom color picker using flutter only #342
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
I added an
IconButton
representing theColorPickerIcon
to theControlsColumn
with customizableCustomColorPosition
enum.leading
or.trailing
relative to thecolors
list and also appearance control withshowCustomColor
boolean both are passed all the way down from the topBetterFeedBack
widget to theControlsColumn
constructor.💡 Motivation and Context
I was on the way to implement a feedback mechanism in a project I am working on and I previously bookmarked this video and as usual I wandered around the repo and found that issue, It was a proposal from ueman the maintainer.
Despite of being Open, I assumed after Recognizing the date that it must have been implemented and I got encouraged when I looked into the code and saw that It hasn't been implemented yet so I felt I could do it and here I am.
Note: I faced some issues while testing the example on Android and you will see the last commit is only in the android and ios folders of the example app. They have nothing to do with the implemented feature.
💚 How did you test it?
I tested it on:
📝 Checklist
🔮 Next steps
After I tested it on my iPhone I noticed a couple of things that can be improved:
The drawing feels a bit rough especially on curves and I think that is because the connections between the path in the painter points are using
lineTo
, It is worth checking out.