Added platform-aware golden image logic #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
There's a bug in
testWidgets
that makes group level test skipping not work. The bug is fixed in Flutter version 2.1.0 (flutter/flutter#76174) but 2.1.0 isn't out on stable yet. We could release this PR now and clean it up a little when 2.1.0 is out (see todo note in PR) or we could wait until the bugfix is out, clean up the PR, and then merge.💡 Motivation and Context
Golden image tests would fail trivially on any platform but OSX. I'm working in Windows and wanted working golden tests for my PRs against this repo.
💚 How did you test it?
Ran the tests with spoofed platforms to verify skipping and image selection works as intended.
📝 Checklist
🔮 Next steps