This repository has been archived by the owner on Nov 1, 2024. It is now read-only.
Added custom header support (such as Auth, User-agent, Connection) #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trdwll
suggested changes
May 2, 2022
| @@ -30,7 +30,7 @@ void UVaRestSubsystem::Deinitialize() | |||
| Super::Deinitialize(); | |||
| } | |||
|
|
|||
| void UVaRestSubsystem::CallURL(const FString& URL, EVaRestRequestVerb Verb, EVaRestRequestContentType ContentType, UVaRestJsonObject* VaRestJson, const FVaRestCallDelegate& Callback) | |||
| void UVaRestSubsystem::CallURL(const FString& URL, EVaRestRequestVerb Verb, TMap<FString, FString> headers, EVaRestRequestContentType ContentType, UVaRestJsonObject* VaRestJson, const FVaRestCallDelegate& Callback) | |||
There was a problem hiding this comment.
Should be a const reference since it's not being modified.
Comment on lines
47
to
49
| for (const TPair<FString, FString>& pair : headers) | ||
| Request->SetHeader(pair.Key, pair.Value); | ||
|
|
There was a problem hiding this comment.
Can you add {} to match the rest of the code?
| @@ -15,10 +15,11 @@ DECLARE_DYNAMIC_DELEGATE_OneParam(FVaRestCallDelegate, UVaRestRequestJSON*, Requ | |||
| USTRUCT() | |||
| struct FVaRestCallResponse | |||
| { | |||
| GENERATED_BODY() | |||
| GENERATED_USTRUCT_BODY() | |||
There was a problem hiding this comment.
This should be GENERATED_BODY as GENERATED_USTRUCT_BODY is old and deprecated.
| @@ -51,7 +52,7 @@ class VAREST_API UVaRestSubsystem : public UEngineSubsystem | |||
| public: | |||
| /** Easy way to process http requests */ | |||
| UFUNCTION(BlueprintCallable, Category = "VaRest|Utility") | |||
| void CallURL(const FString& URL, EVaRestRequestVerb Verb, EVaRestRequestContentType ContentType, UVaRestJsonObject* VaRestJson, const FVaRestCallDelegate& Callback); | |||
| void CallURL(const FString& URL, EVaRestRequestVerb Verb, TMap<FString, FString> headers, EVaRestRequestContentType ContentType, UVaRestJsonObject* VaRestJson, const FVaRestCallDelegate& Callback); | |||
|
Thanks you for your comment. |
|
just updated |
trdwll
reviewed
Jun 19, 2022
| @@ -30,7 +30,7 @@ void UVaRestSubsystem::Deinitialize() | |||
| Super::Deinitialize(); | |||
| } | |||
|
|
|||
| void UVaRestSubsystem::CallURL(const FString& URL, EVaRestRequestVerb Verb, EVaRestRequestContentType ContentType, UVaRestJsonObject* VaRestJson, const FVaRestCallDelegate& Callback) | |||
| void UVaRestSubsystem::CallURL(const FString& URL, EVaRestRequestVerb Verb, const TMap<FString, FString> headers, EVaRestRequestContentType ContentType, UVaRestJsonObject* VaRestJson, const FVaRestCallDelegate& Callback) | |||
There was a problem hiding this comment.
Can you make the headers tmap a const ref?
trdwll
reviewed
Jun 19, 2022
| @@ -51,7 +52,7 @@ class VAREST_API UVaRestSubsystem : public UEngineSubsystem | |||
| public: | |||
| /** Easy way to process http requests */ | |||
| UFUNCTION(BlueprintCallable, Category = "VaRest|Utility") | |||
| void CallURL(const FString& URL, EVaRestRequestVerb Verb, EVaRestRequestContentType ContentType, UVaRestJsonObject* VaRestJson, const FVaRestCallDelegate& Callback); | |||
| void CallURL(const FString& URL, EVaRestRequestVerb Verb, const TMap<FString, FString> headers, EVaRestRequestContentType ContentType, UVaRestJsonObject* VaRestJson, const FVaRestCallDelegate& Callback); | |||
trdwll
approved these changes
Jun 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.