Update and retrieve display name #193
Conversation
…into update-and-retrieve-display-name
…into update-and-retrieve-display-name
server/src/index.ts
Outdated
|
|
||
| const success = await getConnectedUserDisplayName(userId); | ||
| if (success) { | ||
| res.json(success); |
There was a problem hiding this comment.
can you rename this to something other than success. the variable name is not descriptive enough for people to know that it is a displayName: "string". You could rename it displayName.
| @@ -1,6 +1,19 @@ | |||
| import { distanceBetween, geohashForLocation, geohashQueryBounds } from 'geofire-common' | |||
| import { connectedUsersCollection } from '../utilities/firebaseInit' | |||
|
|
|||
| export const getConnectedUserDisplayName = async (socketID: string) => { | |||
| try { | |||
| const snap = await connectedUsersCollection.doc(socketID).get(); | |||
There was a problem hiding this comment.
could you change this to user instead of snap?
|
The API endpoint used for returning the displayName is So I'm going to update the GET route to just return the document in json. This will also prevent us from trying to build more routes to just return one parameter in a user doc. |
…rn all ConnectedUser document information. Updated /users?userId GET endpoint to match this change.
|
Everything has been tested and works 👍 |
Resolves #183
To avoid confusion between functions involving multiple users and those for the current user, I've renamed the
getConnectedUsers.tsfile togetMultipleConnectedUsers.tsand created a seperate file for a function to get the display name for the author of the message.