Switched to publish subscribe model for messages #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderWangY
added a commit
that referenced
this pull request
Apr 12, 2024
* Cronjob works now * Made requested changes * Switched to publish subscribe model for messages (#208) * added pubsub for messages * test * finished pub sub * testing empty secret * Delete server/firebase-secrets.json * added pubsub for messages * test * rebased --------- Co-authored-by: AlexanderWangY <[email protected]> * packages! * Cronjob works now * Made requested changes * packages! * Commented out deleter by default for testing purposes * Removed interface imports --------- Co-authored-by: Alexander Wang <[email protected]> Co-authored-by: AlexanderWangY <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed from message trigger to incoming messages. This allows us to scale to other features easier such as reaction or really anything else. The lag is not that much different and we will implement a greyed out pending message on the user side!
Unit tests will have to be updated to reflect these changes!