Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bottom tab bar #224

Closed
wants to merge 25 commits into from
Closed

Bottom tab bar #224

wants to merge 25 commits into from

Conversation

Phantom0110
Copy link
Contributor

Created a bottom navigation bar. Have yet to implement the disappearing feature when scrolling up the chat.

Phantom0110 and others added 20 commits March 6, 2024 18:05
@Phantom0110
Add this to workflows to test new pull request
d0867bf
@Phantom0110
Testing new workflows with firebase-secret.json file.
a5793b1
@Phantom0110
Updated workflows to make the check detect firebase-secret.json
911032b
@Phantom0110
Testing checks with .env files
d6baa25
@Phantom0110
Testing checks with .env files
4061db6
@Phantom0110
Testing checks with .env files
d7f2bb3
@Phantom0110
Testing checks with .env files
a2764d6
@Phantom0110
Merge branch 'main' into main
7e6adee
@Phantom0110
Testing checks with .env files
0f8628c
@Phantom0110
Merge branch 'main' of https://github.com/Phantom0110/OSC-Proximity-C…
6d5ef5b 
…hat-App
@Phantom0110
Testing check for .env files
47a23ab
@Phantom0110
deleted firebase-secret.json
1e3fcf2
@Phantom0110
testing alternative for checking firebase-secret.json
3862017
@Phantom0110
testing .env files
201c5ce
@Phantom0110
Testing for firebase-secret.json
13fe97b
@Phantom0110
Merge branch 'main' of https://github.com/Phantom0110/OSC-Proximity-C…
d7f3e8f 
…hat-App
@Phantom0110
Merge branch 'main' of https://github.com/Phantom0110/OSC-Proximity-C…
13437d4 
…hat-App
@Phantom0110
recovered
1c25681
@Phantom0110
deleting some silly directory issues
c39c210
@Phantom0110
Merge branch 'ufosc:main' into main
a4d62ad
@AlexanderWangY AlexanderWangY mentioned this pull request May 27, 2024
Closed
AlexanderWangY
AlexanderWangY approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@AlexanderWangY AlexanderWangY left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just make sure to resolve conflicts with the main branch! git checkout main, git pull, git checkout (your branch), git merge/rebase main

@Phantom0110
Copy link
Contributor Author

@AlexanderWangY Review required again.

@AlexanderWangY
Copy link
Collaborator

We will close this for now. Will come back to it soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderWangY AlexanderWangY AlexanderWangY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Phantom0110 @AlexanderWangY