removed function that imported fonts || Issue #242 #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please mention the issue in a fixed #... manner |
KalebE36
changed the title
|
You may not know this but what Alex means is, if you look at closed Pull Requests some of them will say things like "Fixed issue #0000" in the PR comment, where this will change the associated issue to be marked as resolved automatically, if your PR gets merged. Anyways, the fonts look fine after this change, and I can't find anywhere else that should need a similar change, so thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just removed the function that imports fonts. It was not needed since the there is already a global function declaration in index.js.
This repeat declaration was only found in one component and not in any of the other folders within the client/ directory.