Modify Backend User Types #272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
displayNameanduserIconattributes fromConnectedUsertoUserConfiginterfaces inserver/src/types/User.ts. This change is needed as we would like to make display names and profile picture selections permanent (so you can recognize one person you may find in the app multiple times).After this make sure that
ConnectedUsersinside of firebase are created properly. Do this withnpm run test. The test files are located atserver/src/testswhere both of thetest.tsfiles will be run. If any of them have obsolete code feel free to update them as you see fit.