AQMv7 EE2 Compliance: Propagate CMAKE_Fortran_FLAGS_DEBUG into chgres_cube

[BrianCurtis-NOAA]

DESCRIPTION OF CHANGES:

To meet EE2 requirements for AQMv7, a change was made to propagate CMAKE_Fortran_FLAGS_DEBUG into chgres_cube.

AQM uses the ufs-srweather-app to call CMake for UFS_UTILS. CMake configuration here: https://github.com/BrianCurtis-NOAA/ufs-srweather-app/blob/ee2_fixes/sorc/CMakeLists.txt#L227C1-L258

NCO requires that Debug builds have -ftrapuv and -check all in all compile flags for the project.

Upon testing, the -ftrapuv and -check all was set here:

UFS_UTILS/CMakeLists.txt

Line 67 in 2f8675f

set(CMAKE_Fortran_FLAGS_DEBUG "-O0 -check all -ftrapuv")

but it was not making it into (at least) the chgres_cube compile lines.

This one line change fixed that issue.

TESTS CONDUCTED:

If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.

• Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera and WCOSS2).
• Compile branch on Hera using GNU.
• Compile branch in 'Debug' mode on WCOSS2.
• Run unit tests locally on any Tier 1 machine.
• Run relevant consistency tests locally on all Tier 1 machine.

Describe any additional tests performed.

DEPENDENCIES:

None

DOCUMENTATION:

None Added

ISSUE:

None

[BrianCurtis-NOAA]

@GeorgeGayno-NOAA Here is the PR discussed earlier. Would you be able to run testing for me on the task items I have not been able to get to?

[GeorgeGayno-NOAA]

@BrianCurtis-NOAA can you provide more details on how AQM is compiling UFS_UTILS and why this change is needed.

[BrianCurtis-NOAA]

@BrianCurtis-NOAA can you provide more details on how AQM is compiling UFS_UTILS and why this change is needed.

@GeorgeGayno-NOAA I have updated the description, please let me know if you need any more information.

[GeorgeGayno-NOAA]

Thanks for the additional detail. I am not sure why the debug flags are not propagating to chgres. I have no problem when compiling UFS_UTILS stand-alone. What about CMAKE_Fortran_FLAGS_RELEASE? Are those flags being used by chgres?

[BrianCurtis-NOAA]

Thanks for the additional detail. I am not sure why the debug flags are not propagating to chgres. I have no problem when compiling UFS_UTILS stand-alone. What about CMAKE_Fortran_FLAGS_RELEASE? Are those flags being used by chgres?

Yes, it did seem to be using the Release flags.

[BrianCurtis-NOAA]

Thanks for the additional detail. I am not sure why the debug flags are not propagating to chgres. I have no problem when compiling UFS_UTILS stand-alone. What about CMAKE_Fortran_FLAGS_RELEASE? Are those flags being used by chgres?

Yes, it did seem to be using the Release flags.

Let me double check that. I might recall seeing the CMake_Fortran_FLAGS and not the RELEASE specific ones

[BrianCurtis-NOAA]

I tried with default UFS_UTILS and it works fine. Most likely a configuration got mixed up while I was testing. Thanks for your time @GeorgeGayno-NOAA