-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit testing to ocean_merge program #997
base: develop
Are you sure you want to change the base?
Add unit testing to ocean_merge program #997
Conversation
routines into their own library. Write a unit test for the namelist read routine. Fixes ufs-community#944.
recognize IntelLLVM. Fixes ufs-community#944.
the ocean_merge step. Fixes ufs-community#944.
After some thought, I decided to update the |
reviewer comments. Fixes ufs-community#944.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build the latest commit , Ran the default C96.mx100. Identical files as compared to previous runs. Ran the new test on Hera and all tests passed with the updated baselines
DESCRIPTION OF CHANGES:
Refactor the
ocean_merge
code into subroutines. Add unit testing.TESTS CONDUCTED:
If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.
grid_gen
consistency tests locally on all Tier 1 machines. Done using aff1a41. All passed on Jet, Hera, Hercules, Orion and WCOSS2.The current
grid_gen
consistency tests don't exercise theocean_merge
program, so a C192 grid was created using on Hercules using the script in ./driver_scripts. Output orography files from the branch at aff1a41 and the develop at 122010e were identical. It was then decided to update one of the tests to invokeocean_merge
. This was done at afb59a4. See commentDEPENDENCIES:
None.
DOCUMENTATION:
The new
ocean_merge
routines need Doxygen comments.ocean_merge
code. Done on Hera using aff1a41.ISSUE:
Fixes #944.