Feature/gfdlmpv3 (ready for review)

[dustinswales]

Description (*updated on 11/18/2024)

This PR is intended to supersede #162
@RuiyuSun I refactored to code so that GFDL v1 and v3 share as much common code as possible.

For the refactoring, all of the configuration/namelist info is moved into a common module that is referenced by both MP versions and a shared fv_sat_adj.F90. There are default values for the scheme configurations defined within this module, and overwritten by the namelist, if provided. Both the v1 and v3 rely on some of the same parameters, but with different default values. This is handled by introducing a pre-processor directive into the new configuration module.

I also removed the imp_physics_gfdl_v3 flag. GFDL v1 and v3 have their own distinct namelists, so there is no need to have another switch to distinguish v1/v3.
The only differences to run with GFDLv1 or v3 are:

• in the SDF: gfdl_cloud_microphys or gfdl_cloud_microphys_v3 and
• which namelist is added to gfs_phys_nml: V1 nml or V3 nml
• set new pre-processor directive, GFDLMP_v3, to true.

Testing

Tested on Hera using Intel
No changes to GFDL MP v1 enabled baselines (control_iovr4 and hafs_regional_atm)

[RuiyuSun]

@dustinswales This is great and thanks!! I agree that the scheme name in SDF and different namelist name are enough to distinguish the two versions of the scheme. So I think it is good idea to remove the imp_physics_gfdl_v3 flag. Did you forget to remove the flag in the gfdl_cloud_microphysics_v3.F90 file?

What is next?

[dustinswales]

@RuiyuSun Good call. I just removed the flag from the scheme.

Next we need to test that the RTs that use GFDLMP v1 are unchanged (I can do this next week). I can't speak to how the v3 results should differ wrt v1 (I will leave this piece to you)

[RuiyuSun]

@RuiyuSun Good call. I just removed the flag from the scheme.

Next we need to test that the RTs that use GFDLMP v1 are unchanged (I can do this next week). I can't speak to how the v3 results should differ wrt v1 (I will leave this piece to you)

@dustinswales Sounds good.

[RuiyuSun]

@dustinswales How do I check out this code? Thanks!

[dustinswales]

@dustinswales How do I check out this code? Thanks!

git clone --recursive --branch feature/gfdlmpv3 https://github.com/dustinswales/ufs-weather-model.git

[grantfirl]

@dustinswales @RuiyuSun Does this supercede #162 so that it can be closed?

[dustinswales]

@grantfirl Yes. #162 can be closed.
More changes coming to this PR in the coming days.

[grantfirl]

@dustinswales @RuiyuSun Will you let us know when this is ready to review and test?

[dustinswales]

@grantfirl This is ready for review.