Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to radiation, cloud, and land processes for improved surface temperature and radiative flux biases + Allow model_configure to provide a path for FV3ATM output #2581 + Update CICD to move label deletion to Jenkinsfile #2568 #2548

Open
wants to merge 27 commits into
base: develop
Choose a base branch
from

Conversation

rhaesung
Copy link

@rhaesung rhaesung commented Jan 6, 2025

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

Changes from @RuiyuSun and @HelinWei-NOAA.

This PR addresses several key issues identified in the HRv4 and UFS/Noah-MP models, focusing on radiative flux biases, soil thermal conductivity, and evapotranspiration improvements. The goal of these updates is to enhance model performance and better align simulations with observed data.

  1. Cloud/Radiation adjustments:
  • To reduce the high bias in downward shortwave (DSW) radiative flux over land, the cloud number concentration over land has been increased from 100/cm³ to 150/cm³.
  • The convective cloud ice radius in radiation has been reduced from 50 µm to 25 µm.
  • The 2020 summer test results (HRv4Ntc100) show a reduction in the high DSW bias over land and a corresponding reduction in the low bias of upward shortwave (SW) radiative flux at the top of the atmosphere (TOA).
  1. Soil thermal conductivity enhancement:
  • A persistent nighttime and early morning warm surface temperature bias remains in both the GFS/Noah and UFS/Noah-MP models. This is partly due to overlooking the influence of soil organic matter (SOM) on soil thermal conductivity.
  • By incorporating a lookup table developed from the PNNL soil carbon dataset and VIIRS surface type data, the effects of SOM on soil thermal properties have been accounted for.
  • Tests show that including SOM results in better simulation of ground heat flux, reducing heat storage in the soil during the day, and mitigating the nighttime warm bias, particularly over the Great Plains.
  1. Evapotranspiration adjustment:
  • The aquifer hydraulic conductivity has been updated to use the algorithm average rather than the harmonic average. This increases the amount of water uptake by the soil layer, improving evapotranspiration modeling.
  1. Bug Fixes:
  • Snow aging at night: Fixed an issue to allow snow aging to occur at night, ensuring more realistic snow dynamics.
  • Unit correction for potential evaporation: Corrected the unit for potential evaporation from W/m² to mm/s to ensure proper unit consistency and accuracy in the model.

Commit Message:

* UFSWM - Updates to radiation, cloud, and land processes for improved surface temperature and radiative flux biases
  * FV3 - Updates to radiation, cloud, and land processes for improved surface temperature and radiative flux biases
    * ccpp-physics - Updates to radiation, cloud, and land processes for improved surface temperature and radiative flux biases

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • GaeaC5
    • GaeaC6
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@rhaesung
Copy link
Author

rhaesung commented Jan 7, 2025

Confirmed that ufs-community/ccpp-physics@80d5c40 does not impact the results of any tests, so the previous results remain valid.

@jkbk2004
Copy link
Collaborator

@rhaesung can you sync up branches? I may go ahead to do some more pre tests with this pr.

@rhaesung
Copy link
Author

@jkbk2004 Done! Please let me know if see any issues.

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Jan 29, 2025

@rhaesung @FernandoAndrade-NOAA @BrianCurtis-NOAA I confirm this pr runs ok on Derecho: baseline creation and comparison as well. We should let this pr go first. @grantfirl FYI

@jkbk2004 jkbk2004 added Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. jenkins-ort run ORT testing labels Jan 30, 2025
@jkbk2004 jkbk2004 changed the title Updates to radiation, cloud, and land processes for improved surface temperature and radiative flux biases Updates to radiation, cloud, and land processes for improved surface temperature and radiative flux biases + Allow model_configure to provide a path for FV3ATM output #2581 Jan 30, 2025
@FernandoAndrade-NOAA
Copy link
Collaborator

Leaving a note that test_changes.list seems incomplete, additional failures during comparison for:

cpld_control_p8_lnd intel
cpld_restart_p8_lnd intel
cpld_control_gfsv17 intelllvm
cpld_debug_gfsv17 intelllvm
cpld_control_sfs intelllvm
cpld_control_p8 intelllvm
regional_atmaq_debug intel

@jkbk2004 FYI

@jkbk2004 jkbk2004 changed the title Updates to radiation, cloud, and land processes for improved surface temperature and radiative flux biases + Allow model_configure to provide a path for FV3ATM output #2581 Updates to radiation, cloud, and land processes for improved surface temperature and radiative flux biases + Allow model_configure to provide a path for FV3ATM output #2581 + Update CICD to move label deletion to Jenkinsfile #2568 Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. jenkins-ort run ORT testing Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants