feat: support ControllerExtensions extended with .override(...) #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akudev
force-pushed
the
feat/controllerextensions
branch
from
0c5138f to
ba68506
Compare
Recognize (and remove) a dummy function ControllerExtension.use(...) that only exists on TypeScript/ES-class side and takes care of converting the class resulting from SomeExtension.override(...) to the instance type that needs to be presented to TypeScript for the member property. Intentionally does not remove the previous @transformControllerExtension annotation to not disrupt potential users immediately. But it will be removed. Contains some unrelated whitespace fixes for prettier.
akudev
force-pushed
the
feat/controllerextensions
branch
from
ba68506 to
399b507
Compare
petermuessig
previously approved these changes
Jul 11, 2024
Throw error when ControllerExtension.use(...) is not called with one parameter.
|
Ummm... I think the test error is because the error message is not colored but expected to be colored: |
mention possible mistakes
akudev
force-pushed
the
feat/controllerextensions
branch
from
66cba1e to
3777d89
Compare
petermuessig
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recognize (and remove) a dummy function ControllerExtension.use(...)
that only exists on TypeScript/ES-class side and takes care of
converting the class resulting from SomeExtension.override(...) to the
instance type that needs to be presented to TypeScript for the member
property.
Intentionally does not remove the previous @transformControllerExtension
annotation to not disrupt potential users immediately. But it will be
removed.
Contains some unrelated whitespace fixes for prettier.