5 ui5 plugin generation failing #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akudev
reviewed
Sep 17, 2024
generators/app/index.js
Outdated
| { | ||
| type: "input", | ||
| name: "author", | ||
| message: "Who is the author of the application?", |
There was a problem hiding this comment.
Is "application" the right term for an FLP plugin?
There was a problem hiding this comment.
changed it to FLP Plugin
generators/app/templates/readme.md
Outdated
|
|
||
| This project has been generated with 💙 and [easy-ui5](https://github.com/SAP) | ||
| This app demonstrates a setup for developing UI5 applications. |
There was a problem hiding this comment.
I don't think this fits for FLP plugins, does it?
There was a problem hiding this comment.
changed it to FLP Plugin
| </head> | ||
|
|
||
| <body class="sapUiBody sapUShellFullHeight"> |
There was a problem hiding this comment.
the removal of these classes is intentional?
There was a problem hiding this comment.
yes it not required now
|
LGTM - sorry for the late review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.