fix(ui5-tooling-modules): properly resolve local dependencies

Fixes #1068

packages/ui5-tooling-modules/lib/util.js

@@ -296,9 +296,23 @@ module.exports = function (log, projectInfo) {
 			knownDeps.push(npmPackage);
 			let depRoot;
 			try {
-				const depPath = resolveNodeModule(dep, cwd, depPaths, knownDeps);
+				let depPath = resolveNodeModule(dep, cwd, depPaths, knownDeps);
 				if (depPath !== dep) {
-					depRoot = depPath.substring(0, depPath.lastIndexOf("node_modules") + "node_modules".length + 1 + npmPackage.length);
+					// find the closest package.json to the resolved module
+					// (maybe we should break when a package.json is found even though it is not the right one)
+					while (!depRoot && depPath !== cwd && depPath !== "/" && path.basename(depPath) !== "node_modules") {
+						depPath = path.dirname(depPath);
+						const pkgJsonDepPath = path.join(depPath, "package.json");
+						if (existsSync(pkgJsonDepPath)) {
+							const pkgJsonDep = JSON.parse(readFileSync(pkgJsonDepPath, { encoding: "utf8" }));
+							// only if the package.json name matches the dependency name
+							// we consider it as the root of the dependency
+							if (pkgJsonDep.name === dep) {
+								depRoot = depPath;
+								break;
+							}
+						}
+					}
 				} else {
 					// native modules are not part of the node_modules directory
 					// so we need to resolve it late with the package.json

showcases/ui5-app/local/mypackage/index.js

@@ -0,0 +1,3 @@
+module.exports = function mypackage() {
+	return "mypackage";
+};

showcases/ui5-app/local/mypackage/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "mypackage",
+  "version": "1.0.0",
+  "private": true
+}

showcases/ui5-app/package.json

@@ -49,6 +49,7 @@
     "cmis": "^1.0.3",
     "firebase": "^10.12.4",
     "is-plain-object": "^5.0.0",
+    "mypackage": "file:local/mypackage",
     "node-fetch": "^2.7.0",
     "pdfmake": "^0.2.10",
     "punycode": "^2.3.1",

showcases/ui5-app/webapp/controller/Thirdparty.controller.js

@@ -20,8 +20,9 @@ sap.ui.define(
 		"firebase/app", // requires node-fetch@2
 		"firebase/firestore/lite",
 		"signalr",
+		"mypackage",
 	],
-	(Controller, MessageToast, jQuery, xlsx, cmis, supabase, octokit, axios, temporal, stompjs, react, reactdom, zod, pdfMake, pdfFonts, xmljs, firebase, firestore, signalr) => {
+	(Controller, MessageToast, jQuery, xlsx, cmis, supabase, octokit, axios, temporal, stompjs, react, reactdom, zod, pdfMake, pdfFonts, xmljs, firebase, firestore, signalr, mypackage) => {
 		"use strict";
 
 		console.log("[3rdParty] xlsx", xlsx);
@@ -51,6 +52,7 @@ sap.ui.define(
 		}
 
 		console.log("[3rdParty] signalr", signalr, jQuery.connection.hub);
+		console.log("[3rdParty] mypackage", mypackage);
 
 		return Controller.extend("ui5.ecosystem.demo.app.controller.Thirdparty", {
 			onInit() {