Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-tooling-transpile): create absolute path for the replaceVersion import #1024

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

drktfl
Copy link
Contributor

@drktfl drktfl commented Jun 27, 2024

This uses https://nodejs.org/api/url.html#urlpathtofileurlpath-options to make the path an absolute file:// path that should be suitable for using with import on all platforms.

require.resolve() alone results in an absolute path on Windows which cannot be used.

Copy link
Member

@petermuessig petermuessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermuessig petermuessig merged commit 1746d31 into ui5-community:main Jun 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants