Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle case when lessToCompile is provided as a string value #1027

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

marcelschork
Copy link
Contributor

As of now the ui5-tooling-less-task is not working when the configuration parameter lessToCompile is provided as a single string value.

customTasks:
   - name: ui5-tooling-less-task
     beforeTask: minify
     configuration:
       lessToCompile: 'theme/style.less'

A workaround is to use a list style.

customTasks:
   - name: ui5-tooling-less-task
     beforeTask: minify
     configuration:
       lessToCompile: 
         - 'theme/style.less'

I stumbled across it when migrating an old project from a colleague to UI5 tooling v3. We used a custom less compile task supporting single values and the switch to the official UI5 tooling task made me struggling.

@marcelschork marcelschork requested a review from petermuessig July 5, 2024 11:40
@petermuessig
Copy link
Member

LGTM - thanks for the fix

@petermuessig petermuessig merged commit cad15b0 into ui5-community:main Jul 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants