Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhance readme #1029

Merged
merged 3 commits into from
Jul 13, 2024
Merged

feat: Enhance readme #1029

merged 3 commits into from
Jul 13, 2024

Conversation

heimwege
Copy link
Collaborator

Add information about supported CAP runtime to readme of

  • ui5-middleware-cap
  • cds-plugin-ui5

@heimwege heimwege requested a review from petermuessig July 10, 2024 11:41
@heimwege
Copy link
Collaborator Author

Hey @petermuessig 👋🏻
As I've fallen into this trap yesterday I thought this information might be helpful for others as well 🐱

@heimwege heimwege marked this pull request as ready for review July 10, 2024 11:43
@heimwege
Copy link
Collaborator Author

I feel innocent w.r.t those failing tests 🙈

@petermuessig
Copy link
Member

Still wondering where they are coming from - this is more an infrastructural issue here which is related to the pnpm...

@petermuessig
Copy link
Member

@heimwege can you please rebase your change? I made some update to the GH actions and it should work now!

@petermuessig petermuessig merged commit 238d742 into main Jul 13, 2024
5 checks passed
@petermuessig petermuessig deleted the enhance-readme branch July 13, 2024 10:36
@petermuessig
Copy link
Member

THX @heimwege

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants