feat(ui5-tooling-modules): new module resolution #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermuessig
changed the title
marianfoo
pushed a commit
that referenced
this pull request
Nov 5, 2024
* fix(ui5-tooling-modules): properly resolve and match modules in the bundle * feat(ui5-tooling-modules): support browser object for dependencies in package.json * fix(ui5-tooling-modules): avoid lookup when nod node_modules found * feat(ui5-tooling-modules): new module resolution * feat(ui5-tooling-modules): consider package.json mappings * fix(ui5-tooling-modules): fix existsSyncWithCase on Windows * fix(ui5-tooling-modules): performance improvements * fix(ui5-tooling-modules): windows compatibility of caches * fix(ui5-tooling-modules): support linked projects for require.resolve * fix(ui5-tooling-modules): only include depPaths of linked projects --- The new module resolution utilizes the Node.js resolution algorithm. Especially, the handling of the entry points: https://nodejs.org/api/packages.html#package-entry-points and the mapping defined in the browser field in the `package.json` ensures a consistent bundling experience. The module resolution has been centralized in the `resolveModule` function. This is the central place which ensures a consistent module resolution for all places in the `ui5-tooling-modules` script. In addition, the feature implements several caches to avoid unnecessary expensive lookups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new module resolution utilizes the Node.js resolution algorithm. Especially, the handling of the entry points: https://nodejs.org/api/packages.html#package-entry-points and the mapping defined in the browser field in the
package.jsonensures a consistent bundling experience.The module resolution has been centralized in the
resolveModulefunction. This is the central place which ensures a consistent module resolution for all places in theui5-tooling-modulesscript.In addition, the feature implements several caches to avoid unnecessary expensive lookups.