feat(ui5-tooling-modules): support including Assets for Web Components #1112
Conversation
To support all languages and themes, the Seamless Web Components support need to include a reference to the respective Assets file of the dedicated library. The built-in solution using the optional flag includeAssets for the pluginOptions of the webcomponents plugin can include the assets module but this module is loaded too late and in some cases the custom theme and the language isn't available early enough. This requires a rethink of the OpenUI5Support module. Manually the Assets can be included as shown in the Components.js of the sample project: import "@ui5/webcomponents/dist/Assets"; import "@ui5/webcomponents-fiori/dist/Assets";
petermuessig
force-pushed
the
feat/modules/WebCAssets
branch
from
045a257 to
7296ada
Compare
petermuessig
changed the title
|
We need to re-discuss the |
Hm I will look into this later, not sure why this would be too late 🤔 |
|
It's the loading order: webcomponents-fiori > webcomponents > webcomponents-base > OpenUI5Support It's the nature of the import order we have - but we can't change that easily except of moving the OpenUI5Support initialization to a later point in time... Today it works by manually importing the Assets in the Component.js which is also OK but it would require documentation how to include additional styles and exclude the dynamics from the preload otherwise the preload is ~10MB unzipped! 😓 |
#1112) To support all languages and themes, the Seamless Web Components support need to include a reference to the respective Assets file of the dedicated library. The built-in solution using the optional flag includeAssets for the pluginOptions of the webcomponents plugin can include the assets module but this module is loaded too late and in some cases the custom theme and the language isn't available early enough. This requires a rethink of the OpenUI5Support module. Manually the Assets can be included as shown in the Components.js of the sample project: import "@ui5/webcomponents/dist/Assets"; import "@ui5/webcomponents-fiori/dist/Assets";
#1112) To support all languages and themes, the Seamless Web Components support need to include a reference to the respective Assets file of the dedicated library. The built-in solution using the optional flag includeAssets for the pluginOptions of the webcomponents plugin can include the assets module but this module is loaded too late and in some cases the custom theme and the language isn't available early enough. This requires a rethink of the OpenUI5Support module. Manually the Assets can be included as shown in the Components.js of the sample project: import "@ui5/webcomponents/dist/Assets"; import "@ui5/webcomponents-fiori/dist/Assets";
No description provided.