Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seamless webc improve fixtures #1132

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Conversation

H4ze
Copy link
Collaborator

@H4ze H4ze commented Dec 13, 2024

No description provided.

@H4ze H4ze requested review from petermuessig and Thodd December 13, 2024 15:27
Copy link
Member

@petermuessig petermuessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No no, not like that - please fetch the main branch and rebase cherry pick you last commit.

@H4ze H4ze force-pushed the seamless_webc_improve_fixtures branch from 3e58c91 to fefc092 Compare December 20, 2024 10:34
Copy link
Member

@petermuessig petermuessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I just need to adopt the commit message to follow the conventional commit syntax

@petermuessig
Copy link
Member

E2E test issue is not related

@petermuessig petermuessig merged commit f9b810a into main Dec 26, 2024
4 of 5 checks passed
@petermuessig petermuessig deleted the seamless_webc_improve_fixtures branch December 26, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants