fix(ui5-tooling-transpile): support JS-based babel config files #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix, Peter! 🎉 |
BenReim
reviewed
Mar 5, 2024
| // no JSON so we let Babel lookup the configuration file with the Babel API | ||
| const partialConfig = await babel.loadPartialConfigAsync({ cwd }); | ||
| // but we only extract the presets and plugins and ignore the other properties | ||
| babelConfigOptions = { |
There was a problem hiding this comment.
@petermuessig Is it really intended to ignore other babel config options, such as the targets property?
The docu of the task seems to suggest otherwise:
The following configuration options will only be taken into account if no inline babel configuration is maintained in the ui5.yaml as babelConfig or no external babel configuration exists in any configuration file as described in Babels configuration section
There was a problem hiding this comment.
Well, if I enable more, I need to rework the util.js a bit - will require a bit more time then...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #966