Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: housekeeping #606

Merged
merged 12 commits into from
Apr 28, 2024
Merged

chore: housekeeping #606

merged 12 commits into from
Apr 28, 2024

Conversation

vobu
Copy link
Contributor

@vobu vobu commented Apr 19, 2024

sweeping 🧹 this:

  • update chore wdi5 deps (but leave eslint^8)
  • make webdriverio > 8.32.2 a required peer dep to profit from fix fo auto-download error of chrome for testing
  • update examples/**/* deps

@vobu
Copy link
Contributor Author

vobu commented Apr 28, 2024

hey @Siolto - the CAP auth tests currently fail due to a no-more existing UI5 version in the branch of the official bookshop CAP app: https://github.com/SAP-samples/cap-bookshop-wdi5/blob/ae62c547f6e4e42c93578b204fd3b48d043f68a5/app/fiori-apps.html#L16-L17
Would you be so nice 😸 and file a PR bumping it to a LTS? Thanks!

@vobu vobu merged commit bd6ad18 into main Apr 28, 2024
12 of 13 checks passed
@vobu vobu deleted the chore/housekeeping branch April 28, 2024 14:42
@Siolto
Copy link
Collaborator

Siolto commented Apr 28, 2024

hey @Siolto - the CAP auth tests currently fail due to a no-more existing UI5 version in the branch of the official bookshop CAP app: https://github.com/SAP-samples/cap-bookshop-wdi5/blob/ae62c547f6e4e42c93578b204fd3b48d043f68a5/app/fiori-apps.html#L16-L17 Would you be so nice 😸 and file a PR bumping it to a LTS? Thanks!

Ughh... not this topic again^^. We can not simply use the LTS version as this would break the existing tests because after 1.109 there are changes in the Fiori Elements framework which would result in a "complete" refactoring not only of the tests but also of the official tutorial.

I will have a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants