fix lcit initData: affect lcitb's performance

uiuc-hpc · Mar 8, 2024 · 5663f0e · 5663f0e
1 parent afec656
commit 5663f0e
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 4 deletions.
diff --git a/benchmarks/lcitb_pt2pt.cpp b/benchmarks/lcitb_pt2pt.cpp
@@ -6,6 +6,7 @@ using namespace lcit;
 
 void test(Context ctx)
 {
+  initData(ctx);
   int tag = 245 + TRD_RANK_ME;
   //  int peer_rank = ((1 - LCI_RANK % 2) + LCI_RANK / 2 * 2) %
   //  LCI_NUM_PROCESSES; // 0 <-> 1, 2 <-> 3
@@ -74,6 +75,7 @@ void test(Context ctx)
       });
     }
   }
+  freeData(ctx);
 }
 
 int main(int argc, char** args)

diff --git a/lci/backend/ofi/server_ofi.h b/lci/backend/ofi/server_ofi.h
@@ -17,8 +17,8 @@
     int err = (x);                                                            \
     if (err < 0) err = -err;                                                  \
     if (err) {                                                                \
-      LCI_DBG_Assert(false, "err : %s (%s:%d)\n", fi_strerror(err), __FILE__, \
-                     __LINE__);                                               \
+      LCI_Assert(false, "err : %s (%s:%d)\n", fi_strerror(err), __FILE__, \
+                 __LINE__);                                               \
     }                                                                         \
   }                                                                           \
   while (0)                                                                   \

diff --git a/tests/lcit/lcit.h b/tests/lcit/lcit.h
@@ -439,7 +439,6 @@ Context initCtx(Config config)
   LCI_endpoint_init(&ctx.ep, ctx.device, plist);
   LCI_plist_free(&plist);
 
-  initData(ctx);
   if (config.nthreads - config.nprgthreads > 1) {
     ctx.threadBarrier = new ThreadBarrier(config.nthreads - config.nprgthreads);
   }
@@ -450,7 +449,6 @@ void freeCtx(Context& ctx)
 {
   delete ctx.threadBarrier;
   ctx.threadBarrier = nullptr;
-  freeData(ctx);
   freeComp(ctx.config.send_comp_type, &ctx.send_comp);
   freeComp(ctx.config.recv_comp_type, &ctx.recv_comp);
   LCI_endpoint_free(&ctx.ep);

diff --git a/tests/lcit/lcit_many2one.cpp b/tests/lcit/lcit_many2one.cpp
@@ -5,6 +5,7 @@ using namespace lcit;
 
 void test(Context ctx)
 {
+  initData(ctx);
   int rank = LCI_RANK;
   int tag = 245 + TRD_RANK_ME;
 
@@ -70,6 +71,7 @@ void test(Context ctx)
       }
     }
   }
+  freeData(ctx);
 }
 
 int main(int argc, char** args)

diff --git a/tests/lcit/lcit_pt2pt.cpp b/tests/lcit/lcit_pt2pt.cpp
@@ -5,6 +5,7 @@ using namespace lcit;
 
 void test(Context ctx)
 {
+  initData(ctx);
   int rank = LCI_RANK;
   int tag = 245 + TRD_RANK_ME;
   int peer_rank = ((1 - LCI_RANK % 2) + LCI_RANK / 2 * 2) % LCI_NUM_PROCESSES;
@@ -63,6 +64,7 @@ void test(Context ctx)
       }
     }
   }
+  freeData(ctx);
 }
 
 int main(int argc, char** args)