Skip to content

Commit

Permalink
Fix overfiltering of methods by return and parameter types.
Browse files Browse the repository at this point in the history
It should allow protected.
  • Loading branch information
Atsushi Eno committed Aug 29, 2011
1 parent 183f000 commit dbde0b9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
9 changes: 6 additions & 3 deletions JavaClass.java
Original file line number Diff line number Diff line change
Expand Up @@ -438,13 +438,16 @@ public void appendToDocument (Document doc, Element parent)
continue; // Some non-standard flag seems to detect non-declared method on the source e.g. AbstractStringBuilder.append(char)
}

if (!Modifier.isPublic (method.getReturnType ().getModifiers ()))
int rtmods = method.getReturnType ().getModifiers ();
if (!Modifier.isPublic (rtmods) && !Modifier.isProtected (rtmods))
continue;
boolean nonPublic = false;
Class [] ptypes = method.getParameterTypes ();
for (int pidx = 0; pidx < ptypes.length; pidx++)
if (!Modifier.isPublic (ptypes [pidx].getModifiers ()))
for (int pidx = 0; pidx < ptypes.length; pidx++) {
int ptmods = ptypes [pidx].getModifiers ();
if (!Modifier.isPublic (ptmods) && !Modifier.isProtected (ptmods))
nonPublic = true;
}
if (nonPublic)
continue;

Expand Down
2 changes: 0 additions & 2 deletions README
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@ and associated documentation. The information is stored in XML format.

** could be resolved after preview - before release

- android.widget.Filter : CharSequence and string issue
(probably too strong method filtering in jar2xml)
- java.security.Provider.put() : missing in jar2xml output.
maybe disappeared in the shade of Hashtable.put().
- java.net.ssl.KeyStoreBuilderParameters.Parameters and .ctor() : types differ
Expand Down

0 comments on commit dbde0b9

Please sign in to comment.