Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Component Update #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

React Component Update #14

wants to merge 2 commits into from

Conversation

IhsanE
Copy link

@IhsanE IhsanE commented Aug 12, 2016

This change is to update the current countdown-timer to extend React Component. This is a future proofing solution to aid the use of ES6 classes. Facebook recommends the deprecation of ReactClass, I suggest we follow suit.

Also fixes errors that the current implementation has. The following are listed below.

  1. When adding props to component, passing them results in the timer restarting due to colliding logic in componentWillReceiveProps

  2. Misuse of the constructor (as per @rloomba implementation)

-- I believe that although this adds the use of es6, it's necessary as an update to the current branch since the current state is basically unusable by any visitors using up to date libraries (most people I would presume).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant