Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image-webpack-loader and fix vulnerability #4002

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

cgsunkel
Copy link
Contributor

Description of change

The latest version of image-webpack-loader appears to have fixed the issues that were breaking our build last year (for more information see this PR). I have deployed this branch to the demo environment to verify this and everything worked as expected. I've also fixed the security vulnerability as part of this PR.

Checklist

  • Has the branch been rebased to master?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

@paulgain paulgain temporarily deployed to data-hub-fro-chore-imag-qrmwmp September 21, 2021 15:35 Inactive
@cypress
Copy link

cypress bot commented Sep 21, 2021



Test summary

84 0 0 0Flakiness 0


Run details

Project data-hub-frontend
Status Passed
Commit 68eec80
Started Sep 23, 2021 10:48 AM
Ended Sep 23, 2021 10:51 AM
Duration 03:46 💡
OS Linux Debian - 9.13
Browser Chrome 93

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #4002 (68eec80) into master (68e9e63) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4002      +/-   ##
==========================================
- Coverage   83.76%   83.71%   -0.05%     
==========================================
  Files         769      769              
  Lines       13458    13458              
  Branches     2916     2916              
==========================================
- Hits        11273    11267       -6     
- Misses       2185     2191       +6     
Impacted Files Coverage Δ
...anies/apps/match-company/client/MatchDuplicate.jsx 54.54% <0.00%> (-36.37%) ⬇️
src/client/components/Form/hooks/useForm.js 91.72% <0.00%> (-1.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68e9e63...68eec80. Read the comment docs.

@cgsunkel cgsunkel merged commit 08f11f7 into master Sep 23, 2021
@cgsunkel cgsunkel deleted the chore/image-webpack-loader-test branch September 23, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants