Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional MVP document reader functionality #100

Closed
5 tasks done
anjackson opened this issue Dec 2, 2022 · 5 comments
Closed
5 tasks done

Additional MVP document reader functionality #100

anjackson opened this issue Dec 2, 2022 · 5 comments
Labels
enhancement New feature or request Webrecorder Support To be addressed under the ongoing support agreement.

Comments

@anjackson
Copy link
Contributor

anjackson commented Dec 2, 2022

Following initial evaluate, we need to build on the original PDF/ePub implementation #68 and add the following features:

The PDF, viewer does meet this requirements already, although printing can be slow because it currently renders all pages first.

The ePub viewer generally works well but is somewhat confusing because it is so different from the PDF viewer UI. e.g. both can zoom, but the PDF viewer has dedicated buttons whereas the ePub viewer relies on the browser zoom. Ideally, both interfaces would be consistent.

One option is to switch to a UV implementation that supports both formats in a consistent manner. This should be evaluated, with the above requirements (and the core requirements the existing system already meets) kept in mind. I think those core requirements are:

  • Outline (if available)
  • Thumbnails (if available) with position/page number shown on hover
  • Zoom
  • Current position/page indicator
@anjackson anjackson added the enhancement New feature or request label Dec 2, 2022
@anjackson anjackson added the Webrecorder Support To be addressed under the ongoing support agreement. label Jan 13, 2023
@anjackson
Copy link
Contributor Author

Note that in #99 I experimented with a different ePub reader library called Vivliostyle. This could be considered if adding the above functionality to the existing reader is problematic.

@anjackson
Copy link
Contributor Author

Note that the citation proposal #98 does not expose (and does not necessarily require) implementation of the EPUB Canonical Fragment Identifiers.

@anjackson
Copy link
Contributor Author

@tw4l On the Search feature, it is possible to bind it to CTRL-F to use your search rather than the browser page search?

@tw4l
Copy link
Contributor

tw4l commented Jul 27, 2023

@tw4l On the Search feature, it is possible to bind it to CTRL-F to use your search rather than the browser page search?

Sure thing! I'll add it on my list for tomorrow's ukwa-pywb work :) I don't think I can make the browser's find box run the app's search function, but I probably can make it so that CTRL-F opens the in-app search tab and focuses on the input.

@tw4l
Copy link
Contributor

tw4l commented Jul 28, 2023

@anjackson Merged as part of #108 along with a fix for the Reference bug we had before that required viewing a chapter before "Jump to citation" would work.

Only thing to note is that for now jumping to a citation will only highlight the first character of the paragraph - we can discuss coming back to highlighting the whole paragraph if need be after printing but it was proving to be difficult and I wanted to move on to make sure we hit the next milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Webrecorder Support To be addressed under the ongoing support agreement.
Projects
None yet
Development

No branches or pull requests

2 participants