-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional MVP document reader functionality #100
Comments
Note that in #99 I experimented with a different ePub reader library called Vivliostyle. This could be considered if adding the above functionality to the existing reader is problematic. |
Note that the citation proposal #98 does not expose (and does not necessarily require) implementation of the EPUB Canonical Fragment Identifiers. |
@tw4l On the Search feature, it is possible to bind it to |
Sure thing! I'll add it on my list for tomorrow's ukwa-pywb work :) I don't think I can make the browser's find box run the app's search function, but I probably can make it so that CTRL-F opens the in-app search tab and focuses on the input. |
@anjackson Merged as part of #108 along with a fix for the Reference bug we had before that required viewing a chapter before "Jump to citation" would work. Only thing to note is that for now jumping to a citation will only highlight the first character of the paragraph - we can discuss coming back to highlighting the whole paragraph if need be after printing but it was proving to be difficult and I wanted to move on to make sure we hit the next milestone. |
Following initial evaluate, we need to build on the original PDF/ePub implementation #68 and add the following features:
The PDF, viewer does meet this requirements already, although printing can be slow because it currently renders all pages first.
The ePub viewer generally works well but is somewhat confusing because it is so different from the PDF viewer UI. e.g. both can zoom, but the PDF viewer has dedicated buttons whereas the ePub viewer relies on the browser zoom. Ideally, both interfaces would be consistent.
One option is to switch to a UV implementation that supports both formats in a consistent manner. This should be evaluated, with the above requirements (and the core requirements the existing system already meets) kept in mind. I think those core requirements are:
The text was updated successfully, but these errors were encountered: