-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CDT parser include file handling and support recursion for includes #639
Draft
bahnwaerter
wants to merge
8
commits into
ultimate-pa:dev
Choose a base branch
from
bahnwaerter:wip/mb/cdt-include-file-handling
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7407aa4
Add CDT parser option to support recursive adding of include files
bahnwaerter aa78619
Add CDT parser test suite for testing the parsing of C programs
bahnwaerter 073ed36
Fix CDT parser include file handling and support recursion for includes
bahnwaerter 00c8d07
Fix path separator documentation
bahnwaerter 960697a
Allow relative include paths
schuessf fc8cc23
Always use ; in CDTParserTestSuite, not depending on platform
schuessf 70c6641
Always include parent folders, rework recursive computation
schuessf 9b11124
Fix C preprocessor to handle preprocessor macros
bahnwaerter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
/* | ||
* Header file that can be included as source file in test C programs where | ||
* this source file is located using one of the | ||
* | ||
* # include "q-char-sequence" new-line | ||
* # include <h-char-sequence> new-line | ||
* | ||
* preprocessor directives (see C standard, section 6.10.2). | ||
*/ | ||
|
||
typedef struct ret { | ||
int code; | ||
} ret_t; | ||
|
||
static inline ret_t funcFromDirectoryHeaderOne(void) | ||
{ | ||
ret_t ret = { .code = 2 }; | ||
return ret; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
/* | ||
* Header file that can be included as source file in test C programs where | ||
* this source file is located using one of the | ||
* | ||
* # include "q-char-sequence" new-line | ||
* # include <h-char-sequence> new-line | ||
* | ||
* preprocessor directives (see C standard, section 6.10.2). | ||
*/ | ||
|
||
static inline int funcFromDirectoryHeaderTwo(void) | ||
{ | ||
int var = 4; | ||
return var; | ||
} |
11 changes: 11 additions & 0 deletions
11
trunk/examples/CParser/include/subdirectory/additionalHeader.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
/* | ||
* Header file that can be included as source file in test C programs where | ||
* this source file is located using one of the | ||
* | ||
* # include "q-char-sequence" new-line | ||
* # include <h-char-sequence> new-line | ||
* | ||
* preprocessor directives (see C standard, section 6.10.2). | ||
*/ | ||
|
||
int groundTruth = 17; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
//#Safe | ||
/** | ||
* This test program includes a named header file that is searched for in an | ||
* implementation-defined manner (see C standard, section 6.10.2): | ||
* | ||
* # include <h-char-sequence> new-line | ||
* # include "q-char-sequence" new-line | ||
* | ||
* The first directive searches a sequence of implementation-defined places for | ||
* a header identified uniquely by the specified sequence between the '<' and | ||
* '>' delimiters. The second directive causes the replacement of that | ||
* directive by the entire contents of the source file identified by the | ||
* specified sequence between the '"' delimiters. The named source file is | ||
* searched for in an implementation-defined manner. | ||
* | ||
* As usual, a C preprocessor searches for the named source file first in the | ||
* directory containing the current file, then in the same directories | ||
* specified with a sequence between the '<' and '>' delimiters. | ||
*/ | ||
|
||
#include "localHeaderOne.h" | ||
#include "localHeaderTwo.h" | ||
|
||
int main(void) | ||
{ | ||
status_t funcOneRet = funcFromLocalHeaderOne(); | ||
int funcOneVal = funcOneRet.retval; | ||
//@ assert(funcOneVal == 3); | ||
int funcTwoVal = funcFromLocalHeaderTwo(); | ||
//@ assert(funcTwoVal == 5); | ||
return funcOneVal + funcTwoVal; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
//#Safe | ||
/** | ||
* This test program includes a named header file that is searched for in an | ||
* implementation-defined manner (see C standard, section 6.10.2): | ||
* | ||
* # include <h-char-sequence> new-line | ||
* # include "q-char-sequence" new-line | ||
* | ||
* The first directive searches a sequence of implementation-defined places for | ||
* a header identified uniquely by the specified sequence between the '<' and | ||
* '>' delimiters. The second directive causes the replacement of that | ||
* directive by the entire contents of the source file identified by the | ||
* specified sequence between the '"' delimiters. The named source file is | ||
* searched for in an implementation-defined manner. | ||
* | ||
* As usual, a C preprocessor searches for the named source file first in the | ||
* directory containing the current file, then in the same directories | ||
* specified with a sequence between the '<' and '>' delimiters. | ||
*/ | ||
|
||
#include <directoryHeaderOne.h> | ||
#include <directoryHeaderTwo.h> | ||
|
||
int main(void) | ||
{ | ||
ret_t funcOneRet = funcFromDirectoryHeaderOne(); | ||
int funcOneVal = funcOneRet.code; | ||
//@ assert(funcOneVal == 2); | ||
int funcTwoVal = funcFromDirectoryHeaderTwo(); | ||
//@ assert(funcTwoVal == 4); | ||
return funcOneVal + funcTwoVal; | ||
} |
34 changes: 34 additions & 0 deletions
34
trunk/examples/CParser/includeHeadersNonRecursiveSubdirectory.c
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
//#Safe | ||
/** | ||
* This test program includes a named header file that is searched for in an | ||
* implementation-defined manner (see C standard, section 6.10.2): | ||
* | ||
* # include <h-char-sequence> new-line | ||
* # include "q-char-sequence" new-line | ||
* | ||
* The first directive searches a sequence of implementation-defined places for | ||
* a header identified uniquely by the specified sequence between the '<' and | ||
* '>' delimiters. The second directive causes the replacement of that | ||
* directive by the entire contents of the source file identified by the | ||
* specified sequence between the '"' delimiters. The named source file is | ||
* searched for in an implementation-defined manner. | ||
* | ||
* As usual, a C preprocessor searches for the named source file first in the | ||
* directory containing the current file, then in the same directories | ||
* specified with a sequence between the '<' and '>' delimiters. | ||
*/ | ||
|
||
#include <directoryHeaderOne.h> | ||
#include <directoryHeaderTwo.h> | ||
#include <additionalHeader.h> | ||
|
||
int main(void) | ||
{ | ||
ret_t funcOneRet = funcFromDirectoryHeaderOne(); | ||
int funcOneVal = funcOneRet.code; | ||
//@ assert(funcOneVal == 2); | ||
int funcTwoVal = funcFromDirectoryHeaderTwo(); | ||
//@ assert(funcTwoVal == 4); | ||
//@ assert(groundTruth == 17); | ||
return funcOneVal + funcTwoVal + groundTruth; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
//#Safe | ||
/** | ||
* This test program includes a named header file that is searched for in an | ||
* implementation-defined manner (see C standard, section 6.10.2): | ||
* | ||
* # include <h-char-sequence> new-line | ||
* # include "q-char-sequence" new-line | ||
* | ||
* The first directive searches a sequence of implementation-defined places for | ||
* a header identified uniquely by the specified sequence between the '<' and | ||
* '>' delimiters. The second directive causes the replacement of that | ||
* directive by the entire contents of the source file identified by the | ||
* specified sequence between the '"' delimiters. The named source file is | ||
* searched for in an implementation-defined manner. | ||
* | ||
* As usual, a C preprocessor searches for the named source file first in the | ||
* directory containing the current file, then in the same directories | ||
* specified with a sequence between the '<' and '>' delimiters. | ||
*/ | ||
|
||
#include <directoryHeaderOne.h> | ||
#include <directoryHeaderTwo.h> | ||
#include <additionalHeader.h> | ||
|
||
int main(void) | ||
{ | ||
ret_t funcOneRet = funcFromDirectoryHeaderOne(); | ||
int funcOneVal = funcOneRet.code; | ||
//@ assert(funcOneVal == 2); | ||
int funcTwoVal = funcFromDirectoryHeaderTwo(); | ||
//@ assert(funcTwoVal == 4); | ||
//@ assert(groundTruth == 17); | ||
return funcOneVal + funcTwoVal + groundTruth; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
/* | ||
* Header file that can be included as source file in test C programs where | ||
* this source file is located using the | ||
* | ||
* # include "q-char-sequence" new-line | ||
* | ||
* preprocessor directive (see C standard, section 6.10.2). | ||
*/ | ||
|
||
typedef struct status { | ||
int retval; | ||
} status_t; | ||
|
||
static inline status_t funcFromLocalHeaderOne(void) | ||
{ | ||
status_t ret = { .retval = 3 }; | ||
return ret; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
/* | ||
* Header file that can be included as source file in test C programs where | ||
* this source file is located using the | ||
* | ||
* # include "q-char-sequence" new-line | ||
* | ||
* preprocessor directive (see C standard, section 6.10.2). | ||
*/ | ||
|
||
static inline int funcFromLocalHeaderTwo(void) | ||
{ | ||
int var = 5; | ||
return var; | ||
} |
34 changes: 34 additions & 0 deletions
34
trunk/examples/programs/regression/c/preprocessor/preprocessor-conditionals_safe.c
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
//#Safe | ||
/*----------------------------------------------------------------------------- | ||
* C program with preprocessor macros to test macro parsing and substitution | ||
*----------------------------------------------------------------------------- | ||
* Author: Manuel Bentele | ||
* Date: 2023-09-25 | ||
*---------------------------------------------------------------------------*/ | ||
|
||
#undef SELECT_FUNC_ONE | ||
|
||
#define VALUE 100 | ||
|
||
int compute_one(int num) | ||
{ | ||
return num - VALUE; | ||
} | ||
|
||
int compute_two(int num) | ||
{ | ||
return num + VALUE; | ||
} | ||
|
||
#ifdef SELECT_FUNC_ONE | ||
#define FUNC(VAL) compute_one(VAL) | ||
#else | ||
#define FUNC(VAL) compute_two(VAL) | ||
#endif | ||
|
||
int main(void) | ||
{ | ||
int ret = FUNC(VALUE); | ||
//@ assert(ret == 100 + 100); | ||
return ret; | ||
} |
34 changes: 34 additions & 0 deletions
34
trunk/examples/programs/regression/c/preprocessor/preprocessor-conditionals_unsafe.c
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
//#Unafe | ||
/*----------------------------------------------------------------------------- | ||
* C program with preprocessor macros to test macro parsing and substitution | ||
*----------------------------------------------------------------------------- | ||
* Author: Manuel Bentele | ||
* Date: 2023-09-25 | ||
*---------------------------------------------------------------------------*/ | ||
|
||
#define SELECT_FUNC_ONE | ||
|
||
#define VALUE 100 | ||
|
||
int compute_one(int num) | ||
{ | ||
return num - VALUE; | ||
} | ||
|
||
int compute_two(int num) | ||
{ | ||
return num + VALUE; | ||
} | ||
|
||
#ifdef SELECT_FUNC_ONE | ||
#define FUNC(VAL) compute_one(VAL) | ||
#else | ||
#define FUNC(VAL) compute_two(VAL) | ||
#endif | ||
|
||
int main(void) | ||
{ | ||
int ret = FUNC(VALUE); | ||
//@ assert(ret == 100 + 100); | ||
return ret; | ||
} |
16 changes: 16 additions & 0 deletions
16
trunk/examples/programs/regression/c/preprocessor/preprocessor-macro_safe.c
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
//#Safe | ||
/*----------------------------------------------------------------------------- | ||
* C program with preprocessor macro to test macro parsing and substitution | ||
*----------------------------------------------------------------------------- | ||
* Author: Manuel Bentele | ||
* Date: 2023-09-25 | ||
*---------------------------------------------------------------------------*/ | ||
|
||
#define VALUE 100 | ||
|
||
int main(void) | ||
{ | ||
int ret = VALUE; | ||
//@ assert(ret == 100); | ||
return ret; | ||
} |
16 changes: 16 additions & 0 deletions
16
trunk/examples/programs/regression/c/preprocessor/preprocessor-macro_unsafe.c
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
//#Unsafe | ||
/*----------------------------------------------------------------------------- | ||
* C program with preprocessor macro to test macro parsing and substitution | ||
*----------------------------------------------------------------------------- | ||
* Author: Manuel Bentele | ||
* Date: 2023-09-25 | ||
*---------------------------------------------------------------------------*/ | ||
|
||
#define VALUE 100 | ||
|
||
int main(void) | ||
{ | ||
int ret = VALUE; | ||
//@ assert(ret == 200); | ||
return ret; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//#Unsafe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing out the invalid program correctness specifier.