Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support form errors (see issue #15) #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/ngxerror.directive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,19 +58,28 @@ export class NgxErrorDirective implements OnInit, OnDestroy, DoCheck {

this.subscription = Observable.combineLatest(states, errors)
.subscribe(([states, errors]) => {
this.hidden = !(states && errors.control.hasError(errors.errorName));
if (errors.control) {
this.hidden = !(states && errors.control.hasError(errors.errorName));
} else {
this.hidden = !(states && errors.form.hasError(errors.errorName));
}
});

}

ngDoCheck() {
this._states.next(
this.rules.filter((rule) => (this.ngxErrors.control as any)[rule])
this.rules.filter((rule) => {
if (this.ngxErrors.control) {
return (this.ngxErrors.control as any)[rule];
}
return (this.ngxErrors.form as any)[rule];
})
);
}

ngOnDestroy() {
this.subscription.unsubscribe();
}

}
}
60 changes: 46 additions & 14 deletions src/ngxerrors.directive.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Directive, Input, OnChanges, OnDestroy, AfterViewInit } from '@angular/core';
import { Directive, Input, OnChanges, OnDestroy, AfterViewInit, ChangeDetectorRef } from '@angular/core';
import { FormGroupDirective, AbstractControl } from '@angular/forms';

import { BehaviorSubject } from 'rxjs/BehaviorSubject';
Expand All @@ -23,12 +23,16 @@ export class NgxErrorsDirective implements OnChanges, OnDestroy, AfterViewInit {
ready: boolean = false;

constructor(
private form: FormGroupDirective
public form: FormGroupDirective,
private changeDetectorRef: ChangeDetectorRef
) { }

get errors() {
if (!this.ready) return;
return this.control.errors;
if (this.control) {
return this.control.errors;
}
return this.form.errors;
}

get hasErrors() {
Expand All @@ -45,45 +49,73 @@ export class NgxErrorsDirective implements OnChanges, OnDestroy, AfterViewInit {

getError(name: string) {
if (!this.ready) return;
return this.control.getError(name);
if (this.control) {
return this.control.getError(name);
}
return this.form.getError(name);
}

private checkPropState(prop: string, name: string, conditions: ErrorOptions): boolean {
if (!this.ready) return;
const controlPropsState = (
!conditions || toArray(conditions).every((condition: string) => this.control[condition])
const propsState = (
!conditions || toArray(conditions).every(
(condition: string) =>
this.control ? this.control[condition] : this.form[condition]
)
);
if (name.charAt(0) === '*') {
return this.control[prop] && controlPropsState;
if (this.control) {
return this.control[prop] && propsState;
}
return this.form[prop] && propsState;
}
if (this.control) {
return (
prop === 'valid' ? !this.control.hasError(name) : this.control.hasError(name) && propsState
);
}
return (
prop === 'valid' ? !this.control.hasError(name) : this.control.hasError(name) && controlPropsState
prop === 'valid' ? !this.form.hasError(name) : this.form.hasError(name) && propsState
);
}

private checkStatus() {
const control = this.control;
const errors = control.errors;
const form = this.form;
const errors = control ? control.errors : form.errors;
this.ready = true;
if (!errors) return;
for (const errorName in errors) {
this.subject.next({ control, errorName });
if (this.control) {
this.subject.next({ control, errorName });
} else {
this.subject.next({ form, errorName });

// why does this seem necessary? I don't understand
this.changeDetectorRef.detectChanges();
}
}
}

ngOnChanges() {
this.control = this.form.control.get(this.controlName);
if (this.controlName) {
this.control = this.form.control.get(this.controlName);
}
}

ngAfterViewInit() {
setTimeout(() => {
this.checkStatus();
this.control.statusChanges.subscribe(this.checkStatus.bind(this));
if (this.control) {
this.control.statusChanges.subscribe(this.checkStatus.bind(this));
} else {
this.form.statusChanges.subscribe(this.checkStatus.bind(this));
}
});
}

ngOnDestroy() {
this.subject.unsubscribe();
}

}
}
5 changes: 3 additions & 2 deletions src/ngxerrors.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import { AbstractControl } from '@angular/forms';
import { AbstractControl, FormGroupDirective } from '@angular/forms';

export type ErrorOptions = string | string[];

export interface ErrorDetails {
control: AbstractControl,
control?: AbstractControl,
form?: FormGroupDirective,
errorName: string
}