-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A handful of fixes #23
Conversation
As alluded to in ultralytics/yolov5#12572 (comment), if the intent is that the target repository should configure these tools in its own |
@akx ah, I saw this also the other day, but I think this specific commit was when I experimented with removing my email from action.yml. Once I returned it GitHub seems to know it's me. BTW, we have a bot account at https://github.com/ultralytics/UltralyticsAssistant with email [email protected], we probably want to use this account. Let me try to apply it and see what happens. |
@akx oh this is interesting, it seems like the action doesn't have all the required permissions to update PRs from forked repos. This could be a big problem since most PRs arrive that way. |
Yes, GitHub maps commit identities to GitHub identities via email addresses (and you can make a commit look like it's been authored by anyone else lest you sign all of your own commits) – but in any case, it should be
That would be much better, yes 😄 |
The commits, in order:
pyproject.toml
, as this project is not a Python project that would require installation. (Thepyproject.toml
file also would not work, as it attempts a dynamic version configuration where no dynamic version configuration source is present.) It also removes the duplicated configuration frompyproject.toml
.Ultralytics Actions
instead of @glenn-jocher. (git
'suser.name
is not a GitHub username; it should be a realname.) This is good Git hygiene, not to mention that since this will evidently be used in Ultralytics's open-source projects that welcome external contributions, it sounds amiss that @glenn-jocher would be personally auto-formatting PRs.action.yml
file in this repository did not strictly adhere to the GitHub action schema; the type forinputs.default
isstring
. (Your editor should highlight this as you edit the file; mine did.)🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
This PR updates defaults and enhances spelling checks in Ultralytics' GitHub Actions.
📊 Key Changes
tomli
forcodespell
.codespell
command to include a specified ignore-words list and files/directories to skip during the spell check.git config
to use a more generic Ultralytics Actions user for commits made by GitHub Actions.🎯 Purpose & Impact
codespell
parameters reduce false positives by ignoring certain terms and skipping specified files, leading to more accurate spelling checks.These changes enhance the automation of repository maintenance tasks, potentially improving code quality and reducing the manual workload on developers. 🚀