Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo for social_core.backends.keycloak.KeycloakOAuth2 #2258

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

tomamplius
Copy link
Contributor

No description provided.

@davidbgk
Copy link
Contributor

Hello @tomamplius,

Thanks for your contribution, I would say this is something which could be added on a per instance basis with a custom CSS. Is that something that you considered?

@tomamplius
Copy link
Contributor Author

I just reproduced what is done for github, bitbucket and twitter

KeycloakOAuth2 work like GithubOAuth2 etc...

AUTHENTICATION_BACKENDS = (
    "social_core.backends.keycloak.KeycloakOAuth2",
    "social_core.backends.github.GithubOAuth2",
    "social_core.backends.bitbucket.BitbucketOAuth",
    "social_core.backends.twitter.TwitterOAuth",
    "social_core.backends.openstreetmap.OpenStreetMapOAuth",
    "django.contrib.auth.backends.ModelBackend",
)

@davidbgk
Copy link
Contributor

I know, and I doubt that it would be a good long-term strategy to add lines of CSS for all supported backends.

@tomamplius
Copy link
Contributor Author

I one way can be use array in setting like

AUTHENTICATION_BACKENDS_PARAMETER = [
{ keycloak : { "image" : "https://link to keycloak.png" , "label" : "Login with keycloak" }},
{ github : { "image" : "https://link to github.png" , "label" : "Login with github" }},
{ keycloak : { "image" : "https://link to openstreetmap.png" , "label" : "Login with openstreetmap" }}
]

do you agree?

@tomamplius
Copy link
Contributor Author

Yes, no? other way?

@yohanboniface yohanboniface merged commit 30d9e43 into umap-project:master Dec 2, 2024
@yohanboniface
Copy link
Member

Let's go that way for now, and see! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants