Update Shopify and Dynamics to exclude V8 rendering view. #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronaldbarendse
requested changes
Jan 29, 2025
| @@ -15,7 +15,7 @@ public static class Constants | |||
|
|
|||
| public static class RenderingComponent | |||
| { | |||
| public const string DefaultV8ViewPath = AppPluginFolderPath + "/Render/Products.cshtml"; | |||
| public const string DefaultV8ViewPath = AppPluginFolderPath + "/RenderV8/Products.cshtml"; | |||
|
|
|||
| public const string DefaultV9ViewPath = AppPluginFolderPath + "/Render/ProductsV9.cshtml"; | |||
There was a problem hiding this comment.
Would it make sense to change this path to also have the version in the folder name?
Suggested change
| public const string DefaultV9ViewPath = AppPluginFolderPath + "/Render/ProductsV9.cshtml"; | |
| public const string DefaultV9ViewPath = AppPluginFolderPath + "/RenderV9/Products.cshtml"; |
| @@ -4,9 +4,10 @@ | |||
| <ShopifyPropertyEditorFiles>$(MSBuildThisFileDirectory)..\App_Plugins\UmbracoCms.Integrations\Commerce\Shopify\**\*.*</ShopifyPropertyEditorFiles> | |||
| </PropertyGroup> | |||
|
|
|||
| <Target Name="CopyShopifyPropertyEditorAssets" BeforeTargets="Build"> | |||
| <Target Condition=" '$(TargetFramework)' != 'net472' " Name="CopyShopifyPropertyEditorAssets" BeforeTargets="Build"> | |||
There was a problem hiding this comment.
Shouldn't this condition be on the ShopifyPropertyEditorFiles item group instead, since this target needs to run on both .NET Framework and modern .NET?
And instead of adding multiple includes/excludes, use this instead:
<ShopifyPropertyEditorFiles Include="$(ShopifyPropertyEditorFiles)" />
<ShopifyPropertyEditorFiles Condition="'$(TargetFramework)' != 'net472'" Remove="$(MSBuildThisFileDirectory)..\App_Plugins\UmbracoCms.Integrations\Commerce\Shopify\RenderV8\*.*" />
<ShopifyPropertyEditorFiles Condition="'$(TargetFramework)' == 'net472'" Remove="$(MSBuildThisFileDirectory)..\App_Plugins\UmbracoCms.Integrations\Commerce\Shopify\RenderV9\*.*" />
There was a problem hiding this comment.
Thanks for the suggestion @ronaldbarendse , updated accordingly. On V8 it works fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current PR addresses the issue raised with item #239 , for integrations that have a rendering view for Umbraco 8.
While running in production runtime mode, due to the V8 view, a compilation error occurs.
To address this, I've moved the rendering view to a different folder and excluded it during copy if the targeting framework is not .NET 4.7.2.