Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 💄 add custom properties for menu item #773

Merged
merged 1 commit into from
Apr 5, 2024
Merged

feat: 💄 add custom properties for menu item #773

merged 1 commit into from
Apr 5, 2024

Conversation

julczka
Copy link
Contributor

@julczka julczka commented Apr 4, 2024 •
edited
Loading

Allow to change colors of different styles in menu item. closes #769

Description

This Pr adds various custom properties for uui-menu-item, allowing a chenge of color and backgrounf colot for different states.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@julczka
feat: 💄 add custom properties for menu item
52bb4f2 
Allow to change colors of different styles in menu item
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-773.westeurope.azurestaticapps.net

@iOvergaard iOvergaard added the enhancement New feature or request label Apr 5, 2024
@iOvergaard iOvergaard merged commit 229b8da into v1/contrib Apr 5, 2024
11 of 12 checks passed
@iOvergaard iOvergaard deleted the feature/colors-for-uui-menu-item- branch April 5, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support different backgroud colors for uui-menu-item
2 participants
@julczka @iOvergaard