Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installdefaultdatasettings #5705

Merged

Conversation

erikjanwestendorp
Copy link
Contributor

Description

Update installdefaultdatasettings:

  • change 'data type' to 'Data Type'

Type of suggestion

  • Styleguide

Product & version (if relevant)

Umbraco CMS v10, 12 & 13

Copy link
Contributor

@alina-tincas alina-tincas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @erikjanwestendorp thank you for the PR 😊

I have just few suggestions, can you please look into them and let me know what you think?
(and if you agree with them, please make the changes to the other versions as well 💪 )

@erikjanwestendorp
Copy link
Contributor Author

@alina-tincas Thanks for your suggestions. Just updated the PR 😄

@alina-tincas alina-tincas merged commit 4307d70 into umbraco:main Dec 21, 2023
1 check passed
@erikjanwestendorp erikjanwestendorp deleted the update-installdefaultdatasettings branch December 21, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants