Merged content from two articles into one #5985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alina-tincas
requested changes
Mar 26, 2024
There was a problem hiding this comment.
Hi @eshanrnh thank you for the PR 🙌
I have few suggestions, can you please looks into them? 😊 Most of them are in v14, but they should apply to v13 as well (except for macro sections) 👍
14/umbraco-cms/tutorials/editors-manual/working-with-content/README.md
Outdated
Show resolved
Hide resolved
14/umbraco-cms/tutorials/editors-manual/working-with-content/README.md
Outdated
Show resolved
Hide resolved
14/umbraco-cms/tutorials/editors-manual/working-with-content/README.md
Outdated
Show resolved
Hide resolved
14/umbraco-cms/tutorials/editors-manual/working-with-content/README.md
Outdated
Show resolved
Hide resolved
14/umbraco-cms/tutorials/editors-manual/working-with-content/README.md
Outdated
Show resolved
Hide resolved
14/umbraco-cms/tutorials/editors-manual/working-with-content/README.md
Outdated
Show resolved
Hide resolved
14/umbraco-cms/tutorials/editors-manual/working-with-content/README.md
Outdated
Show resolved
Hide resolved
14/umbraco-cms/tutorials/editors-manual/working-with-content/README.md
Outdated
Show resolved
Hide resolved
14/umbraco-cms/tutorials/editors-manual/working-with-content/README.md
Outdated
Show resolved
Hide resolved
…EADME.md Co-authored-by: Alina-Magdalena Tincas <[email protected]>
…EADME.md Co-authored-by: Alina-Magdalena Tincas <[email protected]>
…EADME.md Co-authored-by: Alina-Magdalena Tincas <[email protected]>
…EADME.md Co-authored-by: Alina-Magdalena Tincas <[email protected]>
…EADME.md Co-authored-by: Alina-Magdalena Tincas <[email protected]>
…EADME.md Co-authored-by: Alina-Magdalena Tincas <[email protected]>
…EADME.md Co-authored-by: Alina-Magdalena Tincas <[email protected]>
…EADME.md Co-authored-by: Alina-Magdalena Tincas <[email protected]>
…EADME.md Co-authored-by: Alina-Magdalena Tincas <[email protected]>
…EADME.md Co-authored-by: Alina-Magdalena Tincas <[email protected]>
…EADME.md Co-authored-by: Alina-Magdalena Tincas <[email protected]>
|
Thanks for the review, @alina-tincas 🙌 I've incorporated the comments and made some changes to the placement of the images so that it's consistent throughout the article. |
alina-tincas
approved these changes
Mar 27, 2024
|
Thank you for making the necessary changes #h5YR. All looks good so it can be merged in 💪 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merged content from two articles into one
Type of suggestion
Product & version (if relevant)
Deadline (if relevant)
When should the content be published?