Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update services articles in v14 #5987

Merged
merged 16 commits into from
Mar 27, 2024
Merged

Conversation

alina-tincas
Copy link
Contributor

@alina-tincas alina-tincas commented Mar 26, 2024

Description

What did you add/update/change?
updated services articles in v14

Most articles use same example and a lot more information is found on the API docs. So it does not make sense to keep all those articles.

I have therefore added a link to API docs on the readme file to all services and kept only the articles that have some examples (moved those to the root as well to keep them in one place)

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

cms v14

Deadline (if relevant)

When should the content be published?

@alina-tincas alina-tincas marked this pull request as ready for review March 27, 2024 09:56
Copy link
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @alina-tincas 🙌 I just have a few suggestions.

14/umbraco-cms/reference/management/services/README.md Outdated Show resolved Hide resolved
14/umbraco-cms/reference/management/services/README.md Outdated Show resolved Hide resolved
14/umbraco-cms/reference/management/services/README.md Outdated Show resolved Hide resolved
description: List of services references, how to use them and some examples.
---

# Services References
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if its randomly listed or as per preference but it might make sense to list the services alphabetically.

14/umbraco-cms/reference/management/services/README.md Outdated Show resolved Hide resolved
@alina-tincas
Copy link
Contributor Author

Thank you for the suggestions @eshanrnh 🙌

I have make the necessary changes, can you please check again? 😊

@alina-tincas alina-tincas requested a review from eshanrnh March 27, 2024 14:19
Copy link
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @alina-tincas 🙌#h5YR

@alina-tincas
Copy link
Contributor Author

Thank you for the review @eshanrnh 🙌

As all is good, am merging this in 😊

@alina-tincas alina-tincas merged commit 2b832e4 into main Mar 27, 2024
11 of 12 checks passed
@alina-tincas alina-tincas deleted the update-notification-articles-v14 branch March 27, 2024 14:49
alina-tincas added a commit that referenced this pull request Apr 4, 2024
fix broken links related to removed articles from #5987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants