Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setting-types.md #5992

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Update setting-types.md #5992

merged 2 commits into from
Apr 5, 2024

Conversation

bkclerke
Copy link
Contributor

update creating a setting type for umbraco 12 docs to reflect what folder structure to use.

Description

The documentation was pointing to an HTML file in reference for creating a view and controller. This file lived in the Umbraco Forms folder which appeared to not work when a controller was placed inside. Moving the files to their own folder in a different location worked so I updated the docs to reflect this change.

Type of suggestion

  • Typo/grammar fix
  • [ x ] Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

12

Deadline (if relevant)

When should the content be published?

update creating a setting type for umbraco 12 docs to reflect what folder structure to use.
@alina-tincas
Copy link
Contributor

Hi @bkclerke thank you for the PR 🙌

We will take a look at it as soon as we can 😊

Copy link
Contributor

@jonat123 jonat123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkclerke thanks for the PR! :D

Just have a minor suggestion :-)

@jonat123
Copy link
Contributor

jonat123 commented Apr 5, 2024

@bkclerke To speed things up, I have merged my suggestion 😄

I will then go ahead and merge in the PR 😊

@jonat123 jonat123 merged commit d696034 into umbraco:main Apr 5, 2024
12 checks passed
@bkclerke
Copy link
Contributor Author

bkclerke commented Apr 5, 2024

Thank you @jonat123 ! I didnt realize I needed to approve. Im glad you were able to do it! :D

alina-tincas added a commit that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants