Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue content-apps documentation v13 #5993

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

Yinzy00
Copy link
Contributor

@Yinzy00 Yinzy00 commented Mar 30, 2024

Description

I've updated the documentation for content apps, correcting errors caused by the existing C# code examples and ensuring that it reflects the latest standards and practices.

I also reviewed the C# code examples for versions 10 and 12, confirming their accuracy and reliability. These versions were found to be in good standing without the need for corrections.

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • [ x] Other

Product & version (if relevant)

13

Deadline (if relevant)

When should the content be published?

@alina-tincas
Copy link
Contributor

Hi @Yinzy00 thank you for the PR and for testing the code for the other version as well 🙌

We will take a look a this PR as we can 🙏

@jonat123
Copy link
Contributor

jonat123 commented Apr 4, 2024

@Yinzy00 First of all, thanks for the PR!

I have been trying to test it out to see if I can get it to work with the updated code.

However currently, it seems that it is not working on my end, and I am not sure why 🤔
It shows me the tab:
image

However, it is empty when I go to it 🤔

I do see an error with angular:

angular.js:15697 Error: [$controller:ctrlreg] http://errors.angularjs.org/1.8.3/$controller/ctrlreg?p0=My.WordCounterApp
    at angular.js:99:1
    at angular.js:11787:17
    at ea (angular.js:10818:34)
    at p (angular.js:10603:32)
    at g (angular.js:9942:13)
    at angular.js:9807:30
    at Object.link (angular.js:29993:9)
    at angular.js:1391:15
    at Ca (angular.js:11376:9)
    at p (angular.js:10695:11) '<div class="umb-editor-sub-view__content ng-scope" ng-show="model.active === true" ng-include="model.view">'

And I am wondering whether you have seen something similar when you tested it out? 🤔

@Yinzy00
Copy link
Contributor Author

Yinzy00 commented Apr 4, 2024

Hi @jonat123 , for me it worked as expected.

$controller:ctrlreg means that there is no angjs controller registered with that name.

Did you add the controller script path to the package.manifest?

And is the controller name in the script the same as mentioned in the ng-controller in the view?

@jonat123
Copy link
Contributor

jonat123 commented Apr 5, 2024

@Yinzy00 All looks alright to me 😅

In any case, as the PR is updating the C# code, and I don't have any issues with that, I think it is good to merge in :)

Probably just something on my end 😊

Merging it in :D

@jonat123 jonat123 merged commit 87ae7ed into umbraco:main Apr 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants