Cast api 코드 수정 #38
Merged
Cast api 코드 수정 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 7, 2024 23:23
…cast/OwnCast_backend into enhance/cast-api/29 # Conflicts: # src/main/java/com/umc/owncast/domain/cast/controller/CastController.java # src/main/java/com/umc/owncast/domain/cast/service/CastService.java # src/main/java/com/umc/owncast/domain/cast/service/TTSService.java # src/main/java/com/umc/owncast/domain/sentence/service/SentenceService.java # src/main/java/com/umc/owncast/domain/sentence/service/SentenceServiceImpl.java
yuuddin
changed the base branch from
feat/cast-api/11
to
feat/cast-api-completion
ja7811
approved these changes
Aug 10, 2024
Comment on lines
64
to
85
| private @NotNull ApiResponse<Object> getObjectApiResponse(KeywordCastCreationDTO castRequest, String script) { | ||
| TTSResultDTO ttsResult = ttsService.createSpeech(script, castRequest); | ||
| Double audioLength = ttsResult.getTimePointList().get(ttsResult.getTimePointList().size() - 1); | ||
| int minutes = (int) (audioLength / 60); | ||
| int seconds = (int) Math.round(audioLength % 60); | ||
|
|
||
| Cast cast = Cast.builder() | ||
| .voice(castRequest.getVoice()) | ||
| .audioLength(0) // TODO mp3 파일 길이 가져오기 | ||
| .audioLength(String.format("%02d:%02d", minutes, seconds)) | ||
| .filePath(ttsResult.getMp3Path()) | ||
| .formality(castRequest.getFormality()) | ||
| .member(null) // TODO 회원 기능 만들어지면 자기자신 넣기 | ||
| .language(null) // TODO 회원 기능 만들어지면 언어 설정 넣기 | ||
| .isPublic(false) | ||
| .hits(0L) | ||
| .build(); | ||
| List<Sentence> sentences = sentenceService.mapToSentence( | ||
| script, | ||
| translateService.translate(script), | ||
| ttsResult, | ||
| cast | ||
| ); | ||
| cast.addSentences(sentences); | ||
| castRepository.save(cast); | ||
| sentenceRepository.saveAll(sentences); | ||
| cast = castRepository.save(cast); | ||
| sentenceService.save(script, ttsResult, cast); | ||
|
|
||
| CastScriptDTO response = new CastScriptDTO(cast); | ||
| return ApiResponse.of(SuccessCode._OK, response); | ||
| } |
There was a problem hiding this comment.
리팩토링 해주셨군요 👍
근데 함수명은 바꾸는 게 좋을 거 같아요 (인텔리제이가 추천해준 이름 같은데 의미가 불명확함)
차라리 saveCastCreation 같은 느낌으로 바꾼 다음에
ApiResponse 말고 CastScriptDTO만 반환하게 하는 게 어떨까요
audioLength 구하는 부분은 좋네요
외부 라이브러리 가져와서 mp3 길이 구하고 이런 거 생각하고 있었는데 ssml 태그 사용하면 됐었네..
근데 timePoint 태그가 스크립트 맨 끝에도 붙는 거죠??
There was a problem hiding this comment.
빼놓고 수정 까먹었네요 함수명 수정하겠습니다~~!
- sentenceService.save()가 List<Sentence>를 반환하도록 변경
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DONE