Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Codebuild UnitTest #132

Merged
merged 23 commits into from
Mar 6, 2024

Conversation

williamputraintan
Copy link
Member

@williamputraintan williamputraintan commented Mar 4, 2024

general:

  • Commenting out staging and prod environment in stateless stack - stateful resource does not exist (in stg and prod) and the stateless lookup will fail the pipeline

metadata_manager:

  • mark external dependencies for lambda runtime dependencies (to prevent unresolved path when bundling)

filemanager:

  • Rust installation for codebuild unit test && cargo-lambda
  • disable cdk-nag for filemanager due to rust.aws-cdk-lambda do not have .toString() function which causes an error - it was due to compilation error led to the lambda construct to be undefined but is fixed on subsequent commit/pr

@mmalenic
Copy link
Member

mmalenic commented Mar 4, 2024

Related to #124. I think the Rust compilation is failing because of the --all-targets --all-features which compiles the tests in the Makefile.

@williamputraintan williamputraintan marked this pull request as ready for review March 5, 2024 23:53
@williamputraintan williamputraintan self-assigned this Mar 5, 2024
@williamputraintan williamputraintan merged commit 76a9fa4 into main Mar 6, 2024
2 checks passed
@williamputraintan williamputraintan deleted the fix(postgres-manager)/codebuild-unit-test branch March 6, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants