Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(authorization): Add curators group permissions #830

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

williamputraintan
Copy link
Member

@williamputraintan williamputraintan commented Jan 29, 2025

  • expand AVP schema and authorization to decide based on resource/endpoints
  • add curators and bioinfo group policy to allow certain endpoint in each microservice
    • allow rerun workflow - curators, bioinfo
    • allow sync from external metadata sheet - bioinfo

Closes #829

@williamputraintan williamputraintan added the feature New feature label Jan 29, 2025
@williamputraintan williamputraintan self-assigned this Jan 29, 2025
@reisingerf
Copy link
Member

Looks good to me!
Sorry, a bit behind on this, but these policies only apply to the POST endpoint/methods at this time (e.g. as defined in the action of the policy statement), right?

All other endpoints/methods access is controlled by a default policy or are outside VerifiedPermissions e.g. no authorisation logic needed, authentication is sufficient?

Copy link
Member

@reisingerf reisingerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to give this a go!

@williamputraintan
Copy link
Member Author

All other endpoints/methods access is controlled by a default policy or are outside VerifiedPermissions e.g. no authorisation logic needed, authentication is sufficient?

Yes, so

  • all GET and some WFM endpoints (other than workflow rerun) are not using verified permission so it uses the default cognito JWT verification.
  • Endpoints that use verified permission (metadata ext sync, wfm rerun, FM annotation endpoints) are blocked unless it is whitelisted here based on the roles (admin, curators, bioinfo). The admin (which also be the service JWT token) is given a wildcard to always permit any action

@reisingerf
Copy link
Member

Yup, all good!
Just wondering if / where we'd have the overview of which permissions / access is applied where and how.

No worries! We'll revisit at a later stage when we have a better understanding of all this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat (authorization): Allow curators group to trigger rerun workflowrun
2 participants