-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(filemanager): ensure events are ingested in the correct order #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t known in advance
I will review in tick, soon |
mmalenic
commented
Feb 5, 2024
...workload/stateful/filemanager/database/queries/ingester/aws/update_reordered_for_created.sql
Show resolved
Hide resolved
mmalenic
commented
Feb 6, 2024
brainstorm
requested changes
Feb 6, 2024
...workload/stateful/filemanager/database/queries/ingester/aws/update_reordered_for_created.sql
Show resolved
Hide resolved
lib/workload/stateful/filemanager/filemanager/src/events/aws/collecter.rs
Outdated
Show resolved
Hide resolved
lib/workload/stateful/filemanager/filemanager/src/events/aws/collector_builder.rs
Outdated
Show resolved
Hide resolved
….md, merge collector_builder.rs with collector.rs
…ore values from deleted events
victorskl
approved these changes
Feb 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very detailed impl, Marko. Kudos.! Can't wait to see this in action.
brainstorm
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73
There's still a bit of repetitive code in the application logic and queries, but I think for now it's okay. It will be interesting to benchmark these queries eventually, especially within the
update_reordered_for_*.sql
queries because the select statement locks all rows with the same bucket, key and version_id. Theupdate_reordered_for_*.sql
queries are a bit long, but I think it's okay because it reduces the number of requests that the Lambda function needs to make to the database. Potentially the update and insert queries could be merged to reduce code repetition, with a flag variable indicating if it is a created or deleted event.Changes
created_sequencer
anddeleted_sequencer
values in the database table. The process is:object
tos3_object
because this simplifies the reordering logic.