refactor: Adding improvements from the official Gravity Bridge #351

facundomedica · 2021-12-30T22:38:44Z

Description

In this PR I'm pulling the latest updates made on the official GB to our Peggy module. There'll be more PRs like this in the future.

Gravity-Bridge/Gravity-Bridge@4adc8d1 (improve getUnslashedValset)
Gravity-Bridge/Gravity-Bridge@fa6f638 (don't slash jailidators) <- REQUIRES EXTRA EYES
Gravity-Bridge/Gravity-Bridge@7cf99c4 (use hashmap for slashing confirms)
Gravity-Bridge/Gravity-Bridge@30507ed (Adding events for jailing and attesting with messages)

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

codecov-commenter · 2021-12-30T22:42:22Z

Codecov Report

Merging #351 (dec3173) into main (2bcfeb3) will increase coverage by 0.09%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   37.16%   37.25%   +0.09%     
==========================================
  Files          78       78              
  Lines       10858    10940      +82     
==========================================
+ Hits         4035     4076      +41     
- Misses       6518     6552      +34     
- Partials      305      312       +7

Impacted Files	Coverage Δ
x/peggy/keeper/attestation_handler.go	`3.14% <0.00%> (-0.74%)`	⬇️
x/peggy/keeper/batch.go	`64.03% <0.00%> (ø)`
x/peggy/keeper/keeper.go	`53.41% <57.89%> (+1.67%)`	⬆️
x/peggy/abci.go	`89.54% <80.85%> (-3.87%)`	⬇️

…work/umee into facu/fix-slashing-logic

facundomedica · 2022-01-03T00:43:51Z

@alexanderbez this is the part I'm unsure about:

umee/x/peggy/abci.go

Lines 277 to 281 in 4f8a32d

    
           h.k.StakingKeeper.Slash(ctx, valConsAddr, ctx.BlockHeight(), consPower, params.SlashFractionValset) 
        
           if !validator.IsJailed() { 
        
           	h.k.StakingKeeper.Jail(ctx, valConsAddr) 
        
           }

I think it's ok to slash a jailed validator in this case. But, will that get the same validator slashed on every endBlock?

7cf99c4)

x/peggy/abci.go

x/peggy/keeper/keeper.go

x/peggy/abci.go

alexanderbez · 2022-01-03T17:30:43Z

x/peggy/abci.go

+							consPower,
+							params.SlashFractionValset,
+						)
+						ctx.EventManager().EmitEvent(


see comments below on events 👍

This event is still wrong btw

@alexanderbez pls check now

Nice! Looks good. WDYT about valset_slashing?

In that case we will need valset_slashing and batch_slashing. Idk how much an event type should englobe, or if it should be very narrow

it should be specific to the domain, in this case, valset slashing.

Also, we need to update events.md, which probably could use an entire overhaul, to reflect these new events.

I don't have a strong opinion on slashing vs valset_slashing, I just wanted to suggest it.

alexanderbez · 2022-01-03T17:30:49Z

x/peggy/abci.go

 						h.k.StakingKeeper.Slash(ctx, valConsAddr, ctx.BlockHeight(), consPower, params.SlashFractionValset)
+						ctx.EventManager().EmitEvent(


see comments below on events 👍

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

x/peggy/abci.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

x/peggy/abci.go

alexanderbez · 2022-01-04T17:58:13Z

x/peggy/abci.go

+							consPower,
+							params.SlashFractionValset,
+						)
+						ctx.EventManager().EmitEvent(


This event is still wrong btw

alexanderbez · 2022-01-04T17:58:22Z

x/peggy/abci.go

 						h.k.StakingKeeper.Slash(ctx, valConsAddr, ctx.BlockHeight(), consPower, params.SlashFractionValset)
+						ctx.EventManager().EmitEvent(


x/peggy/abci.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

…work/umee into facu/fix-slashing-logic

…/fix-slashing-logic

alexanderbez · 2022-01-06T22:01:27Z

@facundomedica can we close this?

facundomedica · 2022-01-06T22:15:28Z

@alexanderbez thanks for the reminder. Closed!

Gravity-Bridge/Gravity-Bridge@4adc8d1 (improve getUnslashedValset)

949c763

facundomedica changed the title ~~ref: Refactor adding improvements from the official Gravity Bridge~~ refactor: Adding improvements from the official Gravity Bridge Dec 30, 2021

alexanderbez added the C:x/peggy label Dec 31, 2021

facundomedica added 3 commits January 2, 2022 21:39

don't slash jailidators

70f62d1

don't jail jailidators Gravity-Bridge/Gravity-Bridge@fa6f638

c2ef8d1

Merge branch 'facu/fix-slashing-logic' of https://github.com/umee-net…

4f8a32d

…work/umee into facu/fix-slashing-logic

facundomedica and others added 4 commits January 2, 2022 21:52

finish use hashmap for slashing confirms (Gravity-Bridge/Gravity-Bridge@

f1c5cfb

7cf99c4)

Merge branch 'main' into facu/fix-slashing-logic

69b2b83

added events (Gravity-Bridge/Gravity-Bridge@30507ed)

f125a52

added events (Gravity-Bridge/Gravity-Bridge@30507ed)

97dd68d

facundomedica marked this pull request as ready for review January 3, 2022 17:17

facundomedica requested review from adamewozniak, alexanderbez and toteki as code owners January 3, 2022 17:17

alexanderbez suggested changes Jan 3, 2022

View reviewed changes

facundomedica and others added 2 commits January 3, 2022 18:46

Apply suggestions from code review

22dfc31

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

fixes

a99c4ba

alexanderbez reviewed Jan 3, 2022

View reviewed changes

x/peggy/abci.go Outdated Show resolved Hide resolved

facundomedica and others added 3 commits January 4, 2022 13:22

Update x/peggy/abci.go

7dcb09a

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

fix events in attestation_handler

4aaf0fd

Merge branch 'main' into facu/fix-slashing-logic

2c820de

alexanderbez reviewed Jan 4, 2022

View reviewed changes

facundomedica mentioned this pull request Jan 4, 2022

x/peggy: Remove orchestrator key rotation #364

Closed

4 tasks

facundomedica and others added 5 commits January 4, 2022 16:36

fix events in abci.go

8028ba5

Update x/peggy/abci.go

506245b

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

Merge branch 'facu/fix-slashing-logic' of https://github.com/umee-net…

38b0d92

…work/umee into facu/fix-slashing-logic

Merge branch 'main' into facu/fix-slashing-logic

7290ce5

fix

43e2e2f

facundomedica added 3 commits January 4, 2022 17:35

Merge branch 'facu/fix-slashing-logic' of https://github.com/umee-net…

dec3173

…work/umee into facu/fix-slashing-logic

Merge branch 'main' of https://github.com/umee-network/umee into facu…

e35eb42

…/fix-slashing-logic

valset_slashing and batch_slashing events

cd9fccb

facundomedica closed this Jan 6, 2022

facundomedica deleted the facu/fix-slashing-logic branch January 6, 2022 22:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Adding improvements from the official Gravity Bridge #351

refactor: Adding improvements from the official Gravity Bridge #351

facundomedica commented Dec 30, 2021 •

edited

Loading

codecov-commenter commented Dec 30, 2021 •

edited

Loading

facundomedica commented Jan 3, 2022

alexanderbez Jan 3, 2022

alexanderbez Jan 4, 2022

facundomedica Jan 4, 2022

alexanderbez Jan 4, 2022

facundomedica Jan 4, 2022

alexanderbez Jan 5, 2022

alexanderbez Jan 5, 2022

alexanderbez Jan 3, 2022

alexanderbez Jan 4, 2022

alexanderbez Jan 4, 2022

alexanderbez Jan 4, 2022

alexanderbez commented Jan 6, 2022

facundomedica commented Jan 6, 2022

		h.k.StakingKeeper.Slash(ctx, valConsAddr, ctx.BlockHeight(), consPower, params.SlashFractionValset)
		ctx.EventManager().EmitEvent(

refactor: Adding improvements from the official Gravity Bridge #351

refactor: Adding improvements from the official Gravity Bridge #351

Conversation

facundomedica commented Dec 30, 2021 • edited Loading

Description

Author Checklist

Reviewers Checklist

codecov-commenter commented Dec 30, 2021 • edited Loading

Codecov Report

facundomedica commented Jan 3, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexanderbez commented Jan 6, 2022

facundomedica commented Jan 6, 2022

facundomedica commented Dec 30, 2021 •

edited

Loading

codecov-commenter commented Dec 30, 2021 •

edited

Loading