feat: hot-update 文件生成放到 node_modules 下 #424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 7, 2023 14:17
sorrycc
reviewed
Sep 8, 2023
| let to = self.context.config.output.path.join(filename); | ||
|
|
||
| std::fs::write(to, content).unwrap(); | ||
| let hmr_dir = self.context.root.join("node_modules/.mako/hot_update"); |
There was a problem hiding this comment.
这里用 node_modules/.mako，是不是 runtime 就不需要调整了，改动可以小一点。
There was a problem hiding this comment.
- 如果用 node_modules/.mako，runtime 还是需要改的：不放到 output 目录下了，得把 requireModule.publicPath 去掉。
- 我这里还是保留 /hot_update 呢，感觉语义更清晰些
HiLanXiao
changed the title
|
@stormslowly review 下。 |
stormslowly
reviewed
Sep 11, 2023
| @@ -147,7 +147,7 @@ function createRuntime(makoModules, entryModuleId) { | |||
| invalidate () {}, | |||
| check () { | |||
| const current_hash = requireModule.currentHash(); | |||
| return fetch(`${requireModule.publicPath}${current_hash}.hot-update.json`).then((res)=>{ | |||
| return fetch(`/hot_update/${current_hash}.hot-update.json`).then((res)=>{ | |||
There was a problem hiding this comment.
这里写死 会不会和用户的路由有冲突。业务有一个 hot_update/:id 的路由。这里可以参考下 umi 在 配置了 publicPath 这些资源是怎么 serve 的
原来 public_path 下 也可能定义 /:id
stormslowly
reviewed
Sep 11, 2023
crates/mako/src/dev.rs
Outdated
| @@ -102,35 +138,12 @@ impl DevServer { | |||
| ) | |||
| } | |||
| } | |||
| _ if path.starts_with("hot_update") => { | |||
| get_serve_response(static_serve_hmr.serve(req).await) | |||
There was a problem hiding this comment.
之前 dev server 也写的仓促，有时间精力可以看下这部分有没有更加优雅的 crate 可以用。类似 express 一样 mout 。
HiLanXiao
force-pushed
the
feat/0906_CY
branch
from
f0d8463 to
edea548
Compare
|
这个 pr 先 hold，后续有冲突我来跟进。 |
这块周末我又调整了下，更新了下备注 |
stormslowly
force-pushed
the
master
branch
2 times, most recently
from
7ca5fd6 to
d3c8cfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
验证：
e2e case：
rust server
okam node server（本地 umi 项目）