Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example: fix typescript type and use loader to ensure data is loaded #16

Merged
merged 2 commits into from
Nov 7, 2024
Merged

example: fix typescript type and use loader to ensure data is loaded #16

merged 2 commits into from
Nov 7, 2024

Conversation

Wu-kung
Copy link
Contributor

@Wu-kung Wu-kung commented Nov 6, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0a9e0c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sorrycc
Copy link
Member

sorrycc commented Nov 6, 2024 •
edited
Loading

1、title 尽量用英文
2、非 src 下功能的不要以 fix 和 feat 开头，可以用 example 开头
3、ci 挂了，后续注意下，提 pr 之前建议先跑一遍 pnpm ci

@Wu-kung Wu-kung changed the title fix: 修复 TypeScript 类型问题 example: Resolved TypeScript type and Using Loaders to ensure data is loaded Nov 7, 2024
@sorrycc sorrycc changed the title example: Resolved TypeScript type and Using Loaders to ensure data is loaded example: fix typeScript type and use loader to ensure data is loaded Nov 7, 2024
@sorrycc sorrycc changed the title example: fix typeScript type and use loader to ensure data is loaded example: fix typescript type and use loader to ensure data is loaded Nov 7, 2024
@sorrycc sorrycc merged commit e893412 into umijs:master Nov 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wu-kung @sorrycc