Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support tailwindcss #20

Closed
wants to merge 0 commits into from
Closed

support tailwindcss #20

wants to merge 0 commits into from

Conversation

Xy2002
Copy link
Contributor

@Xy2002 Xy2002 commented Nov 11, 2024

No description provided.

Copy link

changeset-bot bot commented Nov 11, 2024

⚠️ No Changeset found

Latest commit: 69e35f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

src/config.ts Outdated
@@ -47,6 +47,7 @@ const ConfigSchema = z.object({
.optional(),
})
.optional(),
tailwindcss: z.any().optional(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

别用 any 。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里有个问题,该如何确定tailwind配置的类型呢,用一个简化的类型作为zod定义可以吗

Copy link
Member

@xiaohuoni xiaohuoni Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看看能不能写全,或者写常用的,透传的配置,尽量一级的 key 可以写全

src/fishkit/tailwindcss.ts Outdated Show resolved Hide resolved
@sorrycc
Copy link
Member

sorrycc commented Nov 11, 2024

ci 挂了,本地提交前先执行 pnpm ci 。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants